Tools don't check for broken icon path
Bug #1257429 reported by
Alan Pope 🍺🐧🐱 🦄
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical Click Reviewers tools (obsolete) |
Fix Released
|
Undecided
|
Daniel Holbach | ||
Bug Description
On numerous occasions now I've reviewed apps which have passed all tests, install onto the device just fine, but show no icon on the phone.
This can be due to:-
a) A developer script which created the click package, screwing up the .desktop file: "Icon=foo.png" -> "on=foo.png"
b) Absolute path being given in .desktop file: "Icon=/
c) Incorrect filename given in .desktop file: "Icon=foo.png" where the package ships with "bar.png" and no "foo.png" at all.
Can we add a check for some/all of these scenarios, as it causes a needless cycle of re-submission, which is especially frustrating for developers who have no device, so get no test unless one of the reviewers is kind enough to install and check it on device.
Revision history for this message
| Daniel Holbach (dholbach) wrote | #1 |
Revision history for this message
| Daniel Holbach (dholbach) wrote | #2 |
Revision history for this message
| Daniel Holbach (dholbach) wrote | #3 |
Revision history for this message
| Daniel Holbach (dholbach) wrote | #4 |
| Changed in click-reviewers-tools: | |
| assignee: | nobody → Daniel Holbach (dholbach) |
| status: | New → Fix Committed |
| Changed in click-reviewers-tools: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
a) and b) should be resolved according to the code.
c) theoretically isn't hard to do (if you just want to know "is the icon file in the package?"). What's harder to support are two cases
- is the icon for it in somewhere in /usr/share/icons/?
- does the author specify 'rocknroll-app' instead of 'rocknroll-