The "shared" code should be a shared library
Bug #1341502 reported by
Alan Griffiths
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Wishlist
|
Alan Griffiths | ||
| mir (Ubuntu) |
Fix Released
|
Wishlist
|
Unassigned | ||
Bug Description
[src|include]
To avoid loading duplicate code these facilities should be provided by a (versioned) shared library. (It is distinct from libmirplatform as that is server-side only.)
In addition these .a files lead to us breaking the principle that "in examples of client code we don't do what client's can't do". Vis: we have examples that link against mirprotobuf and mirsharedgeometry (which are not packaged).
Related branches
lp:~mir-team/mir/libmircommon
- Cemil Azizoglu (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Alan Griffiths: Abstain
- Alexandros Frantzis (community): Approve
- Chris Halse Rogers: Needs Fixing
- Kevin DuBois (community): Approve
-
Diff: 469 lines (+100/-44)26 files modified3rd_party/android-input/android/CMakeLists.txt (+0/-1)
debian/control (+21/-4)
debian/libmircommon-dev.install (+1/-0)
debian/libmircommon1.install (+1/-0)
examples/CMakeLists.txt (+1/-6)
src/client/CMakeLists.txt (+1/-7)
src/client/android/CMakeLists.txt (+1/-0)
src/client/lttng/CMakeLists.txt (+0/-1)
src/client/rpc/CMakeLists.txt (+0/-2)
src/platform/CMakeLists.txt (+1/-1)
src/platform/graphics/CMakeLists.txt (+0/-1)
src/platform/graphics/android/CMakeLists.txt (+2/-3)
src/server/CMakeLists.txt (+1/-7)
src/server/frontend/CMakeLists.txt (+1/-1)
src/server/report/lttng/CMakeLists.txt (+0/-1)
src/shared/CMakeLists.txt (+23/-6)
src/shared/env/CMakeLists.txt (+6/-0)
src/shared/geometry/CMakeLists.txt (+5/-0)
src/shared/graphics/android/CMakeLists.txt (+0/-2)
src/shared/input/CMakeLists.txt (+6/-0)
src/shared/logging/CMakeLists.txt (+6/-0)
src/shared/protobuf/CMakeLists.txt (+5/-0)
src/shared/report/lttng/CMakeLists.txt (+6/-0)
src/shared/sharedlibrary/CMakeLists.txt (+6/-0)
src/shared/thread/CMakeLists.txt (+6/-0)
tests/unit-tests/CMakeLists.txt (+0/-1)
| Changed in mir: | |
| assignee: | nobody → Alan Griffiths (alan-griffiths) |
| Changed in mir: | |
| importance: | Undecided → Wishlist |
| Changed in mir: | |
| status: | New → In Progress |
| milestone: | none → 0.5.0 |
| description: | updated |
| description: | updated |
| Changed in mir: | |
| milestone: | 0.5.0 → 0.6.0 |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #2 |
| Changed in mir (Ubuntu): | |
| importance: | Undecided → Wishlist |
| status: | New → Fix Released |
To post a comment you must log in.
Fix committed into lp:mir/devel at revision None, scheduled for release in mir, milestone Unknown