Canonical Click Reviewers tools (obsolete)

click-review tools dies when finds tilde in ini file

Bug #1371692 reported by Victor Tuson Palau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Click Reviewers tools (obsolete)
Fix Released
High
Unassigned

Bug Description

Using click-buddy I get the following error with reviewing a click that contais a tilde in the scope ini file.

Now executing: click-review ./com.canonical.elpais_0.7_armhf.click
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/clickreviews/cr_scope.py", line 60, in _extract_scopes
    d["scope_config"].read(ini_fn)
  File "/usr/lib/python3.4/configparser.py", line 672, in read
    self._read(fp, filename)
  File "/usr/lib/python3.4/configparser.py", line 993, in _read
    for lineno, line in enumerate(fp, start=1):
  File "/usr/lib/python3.4/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 33: ordinal not in range(128)

Revision history for this message
Victor Tuson Palau (vtuson) wrote :
Revision history for this message
Victor Tuson Palau (vtuson) wrote :
Revision history for this message
Daniel Holbach (dholbach) wrote :

Hum... when I download the click file and run click-review on it, it works for me.

daniel@daydream:~$ click-review com.canonical.elpais_0.7_armhf.click
com.canonical.elpais_0.7_armhf.click: pass
daniel@daydream:~$

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

I also cannot reproduce this. What is the output of:
$ set | egrep '^LC'

Changed in click-reviewers-tools:
status: New → Incomplete
Jamie Strandboge (jdstrand)
Changed in click-reviewers-tools:
status: Incomplete → In Progress
status: In Progress → Incomplete
Revision history for this message
Victor Tuson Palau (vtuson) wrote :

maybe is fixed, I will check again

Revision history for this message
Chris Wayne (cwayne) wrote :

I've seen this intermittently, where it will crash once, then running it an hour later will fail. The problem is, I've seen it crash when the automated reviews are run after uploading to the store

Revision history for this message
Chris Wayne (cwayne) wrote :

cwayne@boomer:~/Projects/scopes/wiki-nearby$ set | egrep '^LC'
cwayne@boomer:~/Projects/scopes/wiki-nearby$

Revision history for this message
Chris Wayne (cwayne) wrote :

After some investigation this seems to *always* happen to me on the first time click-review is called on such a scope. Subsequent calls work as expected. The issue here is that that it fails the first time it's run when uploaded to the store, so the packages are rejected.

Changed in click-reviewers-tools:
status: Incomplete → Confirmed
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

I can confirm this with click-buddy. If I run click-review directly, it doesn't trace back.

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

click-buddy does this:
export LC_ALL=C
...
click build $installdir

'click build' will run click-review. If you remove the 'LC_ALL=C', then click-review does not fail. You can also cause click-review to fail with:
LC_ALL=C click-review ./com.canonical.elpais_0.7_armhf.click

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

This was fixed in r290 and will be included in click-reviewers-tools 0.19.

Changed in click-reviewers-tools:
status: Confirmed → Fix Committed
Jamie Strandboge (jdstrand)
Changed in click-reviewers-tools:
importance: Undecided → High
Daniel Holbach (dholbach)
Changed in click-reviewers-tools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.