Should not check for "id" attribute in Online Account files
Bug #1380534 reported by
Alberto Mardegan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical Click Reviewers tools (obsolete) |
Fix Released
|
Undecided
|
Jamie Strandboge |
Bug Description
While the root elements of the XML files read by Online Accounts do indeed need to contain an "id" attribute, the source files given to the OA hooks don't need to contain that. The reason is that these files are being processed by a click hook before being installed to their final location, and this hook takes care of adding the "id" attribute and making sure it matches the installed filename.
if fact, when asked how to created .application or .service files, I usually give examples which don't contain the "id" attribute.
So, please remove those checks for the "id" attribute for .application, .service and .provider files.
Related branches
Changed in click-reviewers-tools: | |
assignee: | nobody → Jamie Strandboge (jdstrand) |
status: | New → In Progress |
Changed in click-reviewers-tools: | |
status: | In Progress → Fix Committed |
Changed in click-reviewers-tools: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.