stdlib.go misses packages

Bug #1393583 reported by Michael Hudson-Doyle
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gccgo-go (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Hi, somehow the list of stdlib packages in stdlib.go is missing a couple of standard library packages. This adds them (verified by diffing against the output of go list std).

Tags: patch
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "gccgo-stdlib-fix.diff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Unfortunately, it failed to build, can you please look at that?

make[2]: Entering directory '/build/buildd/gccgo-go-1.2.1/src/cmd/go'
gccgo -o _gccgo-go_ -c -g -O2 -fstack-protector-strong discovery.go fix.go go11.go list.go pkg.go testflag.go vcs.go build.go doc.go fmt.go help.go main.go run.go signal_unix.go test.go version.go clean.go env.go get.go http.go signal.go tool.go vet.go zdefaultcc.go stdlib.go
stdlib.go:141:31: error: expected operand
  "unicode/utf8": true,
                               ^
stdlib.go:141:31: error: expected ',' or '}'
pkg.go:480:6: error: expected map index on right hand side
   if _, ok := stdlib[path]; ok && buildContext.Compiler == "gccgo" {
      ^
test.go:372:8: error: expected map index on right hand side
     if _, ok := stdlib[path]; ok && buildContext.Compiler == "gccgo" {
        ^
test.go:538:6: error: expected map index on right hand side
   if _, ok := stdlib[path]; ok && buildContext.Compiler == "gccgo" {
      ^
test.go:548:6: error: expected map index on right hand side
   if _, ok := stdlib[path]; ok && buildContext.Compiler == "gccgo" {
      ^
Makefile:36: recipe for target 'build' failed
make[2]: *** [build] Error 1

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Hi, thanks for looking at it. I think what's happened is that the patch headers (the "@@ -0,0 +1,141 @@" bit) are wrong in the version you built. They are right in the version I uploaded, so I don't know what happened there.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gccgo-go - 1.2.1-0ubuntu6

---------------
gccgo-go (1.2.1-0ubuntu6) vivid; urgency=medium

  * Fix patch syntax error I introduced in previous upload.
 -- Dmitry Shachnev <email address hidden> Fri, 21 Nov 2014 18:06:06 +0300

Changed in gccgo-go (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.