[utopic] btrfs: label should not contain return char
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| linux (Ubuntu) |
Invalid
|
Low
|
Colin Ian King | ||
| Utopic |
Fix Released
|
Undecided
|
Colin Ian King | ||
Bug Description
SRU Justification:
[Impact]
Minor impact: It is possible to introduce a newline into the btrfs label output from the btrfs sys file /sys/fs/
[Fix]
clean upstream cherry pick 48fcc3ff7dce013
[Testcase]
The commit contains a suitable testcase, see below:
TEST_DEV=/dev/vdb
TEST_DIR=
umount /home/sat/mnt
mkfs.btrfs -f $TEST_DEV
UUID=$(btrfs fi show $TEST_DEV | head -1 | sed -e 's/.*uuid: \([-0-9a-
mount $TEST_DEV $TEST_DIR
LABELFILE=
echo "Test for empty label..." >&2
LINES="$(cat $LABELFILE | wc -l | awk '{print $1}')"
RET=0
if [ $LINES -eq 0 ] ; then
echo '[PASS] Trailing \n is removed correctly.' >&2
else
echo '[FAIL] Trailing \n still exists.' >&2
RET=1
fi
echo "Test for non-empty label..." >&2
echo testlabel >$LABELFILE
LINES="$(cat $LABELFILE | wc -l | awk '{print $1}')"
if [ $LINES -eq 1 ] ; then
echo '[PASS] Trailing \n is removed correctly.' >&2
else
echo '[FAIL] Trailing \n still exists.' >&2
RET=1
fi
exit $RET
This is to be SRU'd for utopic only, trusty does not have this interface supported and this fix is carried in vivid.
| Changed in linux (Ubuntu): | |
| importance: | Undecided → Low |
| status: | New → In Progress |
| assignee: | nobody → Colin Ian King (colin-king) |
| Changed in linux (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Changed in linux (Ubuntu Utopic): | |
| status: | New → Fix Committed |
| Changed in linux (Ubuntu): | |
| status: | Fix Committed → Invalid |
| Changed in linux (Ubuntu Utopic): | |
| assignee: | nobody → Colin Ian King (colin-king) |
| Brad Figg (brad-figg) wrote | #1 |
| tags: | added: verification-needed-utopic |
| Colin Ian King (colin-king) wrote | #2 |
| tags: |
added: verification-done-utopic removed: verification-needed-utopic |
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in linux (Ubuntu Utopic): | |
| status: | Fix Committed → Fix Released |
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-
If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.
See https:/