Mir

Exceptions thrown due to EGL failures don't include EGL error codes

Bug #1444938 reported by Alexandros Frantzis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Alexandros Frantzis
Mir 0.13.0
mir (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Exceptions thrown due to EGL failures don't include EGL error codes, making it hard to uncover the cause of the failure, especially in reports coming from users and production systems.

See original description

Related branches

lp:~afrantzis/mir/report-egl-errors-in-exceptions
PS Jenkins bot (community): Approve (continuous-integration)
Kevin DuBois (community): Approve
Alan Griffiths: Approve
Robert Carr (community): Approve
Diff: 625 lines (+267/-32)
15 files modified
src/include/platform/mir/graphics/egl_error.h (+40/-0)
src/platform/graphics/CMakeLists.txt (+1/-0)
src/platform/graphics/egl_error.cpp (+72/-0)
src/platform/graphics/egl_resources.cpp (+3/-2)
src/platform/symbols.map (+1/-0)
src/platforms/android/server/buffer.cpp (+3/-2)
src/platforms/android/server/gl_context.cpp (+6/-10)
src/platforms/mesa/server/buffer_allocator.cpp (+2/-1)
src/platforms/mesa/server/display_helpers.cpp (+9/-7)
src/server/graphics/nested/display.cpp (+6/-5)
src/server/graphics/nested/display_buffer.cpp (+2/-1)
src/server/graphics/offscreen/display.cpp (+3/-2)
src/server/graphics/surfaceless_egl_context.cpp (+3/-2)
tests/unit-tests/graphics/CMakeLists.txt (+1/-0)
tests/unit-tests/graphics/test_egl_error.cpp (+115/-0)
lp:ubuntu/wily-proposed/mir
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.13.0
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Also be wary of bug 1381398. I guess we can still resolve both independently.

Alexandros Frantzis (afrantzis)
summary: - Exceptions thrown due to EGL and GL failure don't include EGL/GL error
- codes
+ Exceptions thrown due to EGL failures don't include EGL error codes
description: updated
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.13.0

Changed in mir:
status: In Progress → Fix Committed
Alan Griffiths (alan-griffiths)
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.13.1+15.10.20150520-0ubuntu1

---------------
mir (0.13.1+15.10.20150520-0ubuntu1) wily; urgency=medium

  [ Cemil Azizoglu ]
  * New upstream release 0.13.1 (https://launchpad.net/mir/+milestone/0.13.1)
    - ABI summary: No ABI break. Servers and clients do not need rebuilding.
      . Mirclient ABI unchanged at 8
      . Mircommon ABI unchanged at 4
      . Mirplatform ABI unchanged at 7
      . Mirserver ABI unchanged at 31
    - Bug fixes:
      . Can't load app purchase UI without a U1 account (LP: #1450377)
      . Crash because uncaught exception in mir::events::add_touch (LP: #1437357)

 -- CI Train Bot <email address hidden> Wed, 20 May 2015 21:20:15 +0000

Changed in mir (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.