snapcraft.yaml needs to make all stages dirty (was: the can't add file without recreating entire package)
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Snapcraft |
Fix Released
|
Wishlist
|
Kyle Fazzari | ||
Bug Description
I am running snapcraft assemble (qml plugin) on ted's branch lp:~ted/+junk/digitalsign
while iterating over the package, I added 1 new file in ./pic.jpg and edited snapcraft.yaml accordingly:
parts:
qml:
plugin: qml
digitalsign:
plugin: copy
mkdirs:
- bin
files:
digitalsign: bin/digitalsign
digitalsi
pic.jpg: pic.jpg
snappy-metadata: meta
rerunning snapcraft assemble will not pull in the new file, as it's skipping the build stage:
olli@joe-
Skipping pull digitalsign (already ran)
Skipping build digitalsign (already ran)
Skipping stage digitalsign (already ran)
Snapping digitalsign
...
upon deleting ./snap/ ./parts/ ./stage/ the file is being pulled in:
...
Building digitalsign
cp --preserve=all -R digitalsign /home/olli/
cp --preserve=all -R digitalsign.qml /home/olli/
cp --preserve=all -R pic.jpg /home/olli/
...
while not critical (workaround: delete files, start over) it's imho a bad experience as it can be expected that developers will iterate over the package quite frequently, rebuilding is taking longer time and thus not desirable
| Michael Vogt (mvo) wrote | #1 |
| Changed in snapcraft: | |
| importance: | Undecided → High |
| status: | New → Confirmed |
| summary: |
- can't add file without recreating entire package + snapcraft.yaml needs to make all stages dirty (was: the can't add file + without recreating entire package) |
| tags: | added: first-steps |
| Changed in snapcraft: | |
| milestone: | none → 0.4 |
| Changed in snapcraft: | |
| milestone: | 0.4 → none |
| Leo Arias (elopio) wrote | #2 |
| Changed in snapcraft: | |
| status: | Confirmed → Invalid |
| Changed in snapcraft: | |
| status: | Invalid → Triaged |
| Changed in snapcraft: | |
| milestone: | none → 2.2 |
| Changed in snapcraft: | |
| importance: | High → Wishlist |
| Changed in snapcraft: | |
| milestone: | 2.2 → none |
| Changed in snapcraft: | |
| milestone: | none → next |
| Changed in snapcraft: | |
| milestone: | 2.3 → next |
| Changed in snapcraft: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Kyle Fazzari (kyrofa) |
| Changed in snapcraft: | |
| milestone: | 2.4 → next |
| Changed in snapcraft: | |
| milestone: | next → none |
| Changed in snapcraft: | |
| milestone: | none → 2.7 |
| Changed in snapcraft: | |
| milestone: | 2.7 → none |
| Changed in snapcraft: | |
| milestone: | none → 2.8 |
| Sergio Schvezov (sergiusens) wrote | #3 |
| Changed in snapcraft: | |
| status: | In Progress → Fix Committed |
| status: | Fix Committed → In Progress |
| Kyle Fazzari (kyrofa) wrote | #4 |
| Kyle Fazzari (kyrofa) wrote | #5 |
| Kyle Fazzari (kyrofa) wrote | #6 |
| Kyle Fazzari (kyrofa) wrote | #7 |
| Changed in snapcraft: | |
| status: | In Progress → Fix Committed |
| Changed in snapcraft: | |
| status: | Fix Committed → Fix Released |
It appears that snapcraft was not realizing that it needs to rebuild everything when the snapcraft.yaml file changes. I.e. if the file changes we need to "dirty" all previous stages and run the equivalent of "--force" internally.