IsADirectoryError: [Errno 21] Is a directory: '/tmp/clickreview-h712bz1m/'

Bug #1522777 reported by Daniel Holbach
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Click Reviewers tools (obsolete)
Fix Released
Undecided
Unassigned

Bug Description

daniel@daydream:~$ click-review com.ubuntu.docviewer_2.0.223_armhf.click
Traceback (most recent call last):
  File "/usr/bin/click-review", line 138, in <module>
    main()
  File "/usr/bin/click-review", line 132, in main
    results.run_all_checks()
  File "/usr/bin/click-review", line 105, in run_all_checks
    self._run_module_checks(module)
  File "/usr/bin/click-review", line 90, in _run_module_checks
    review = modules.init_main_class(module, self.click_fn)
  File "/usr/lib/python3/dist-packages/clickreviews/modules.py", line 74, in init_main_class
    ob = init_object(click_file)
  File "/usr/lib/python3/dist-packages/clickreviews/cr_url_dispatcher.py", line 49, in __init__
    (full_fn, jd) = self._extract_url_dispatcher(app)
  File "/usr/lib/python3/dist-packages/clickreviews/cr_url_dispatcher.py", line 62, in _extract_url_dispatcher
    fh = open_file_read(fn)
  File "/usr/lib/python3/dist-packages/clickreviews/cr_common.py", line 738, in open_file_read
    orig = codecs.open(path, 'r', "UTF-8")
  File "/usr/lib/python3.5/codecs.py", line 895, in open
    file = builtins.open(filename, mode, buffering)
IsADirectoryError: [Errno 21] Is a directory: '/tmp/clickreview-h712bz1m/'
daniel@daydream:~$

Revision history for this message
Daniel Holbach (dholbach) wrote :

The issue was an empty 'urls' definition:

     "hooks": {
         "docviewer": {
             "apparmor": "docviewer.apparmor",
             "content-hub": "docviewer-content.json",
             "desktop": "com.ubuntu.docviewer.desktop",
             "urls": ""
         }
     },

Revision history for this message
Daniel Holbach (dholbach) wrote :

 Here's a patch for the issue. I'm just not sure how to write a test for it.

Changed in click-reviewers-tools:
status: New → Fix Committed
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

This was fixed in 0.35.

Changed in click-reviewers-tools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Patches

Remote bug watches

Bug watches keep track of this bug in other bug trackers.