dpkg: FTBFS (amd64/gcc-4.0): array type has incomplete element type

Automatically imported from Debian bug report #299699 http://bugs.debian.org/299699

Message-Id: <email address hidden>
Date: Tue, 15 Mar 2005 22:51:55 +0100
From: Andreas Jochens <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: dpkg: FTBFS (amd64/gcc-4.0): array type has incomplete element type

Package: dpkg
Severity: normal
Tags: patch

Hello,

the latest version of gcc-4.0 is even more restrictive than the previous
ones. There is a new error message 'array type has incomplete element type'
for constructs like 'extern struct st x[];' when 'struct st' has not
been defined.

When building 'dpkg' on amd64 with gcc-4.0,
I get the following error:

gcc -g -O2 -Wall -Wwrite-strings -Wpointer-arith -Wimplicit -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wbad-function-cast -Wcast-qual -Wcast-align -Winline -Wmissing-noreturn -Wsign-compare -DHAVE_CONFIG_H -D_GNU_SOURCE -DLOCALEDIR=\"/usr/share/locale\" -I../../intl -I../intl -I../../include -I../.. -I../../lib -I../include -I.. -I. -I../../optlib -DUSE_ZLIB -DUSE_BZ2LIB -DCOPYINGFILE=\"/usr/share/doc/dpkg/copyright\" -c ../../lib/dump.c
In file included from ../../lib/dump.c:37:
../../include/parsedump.h:33: error: array type has incomplete element type
../../lib/dump.c: In function 'w_charfield':
../../lib/dump.c:95: warning: cast discards qualifiers from pointer target type
../../lib/dump.c: In function 'w_booleandefno':
../../lib/dump.c:133: warning: cast discards qualifiers from pointer target type
make[3]: *** [dump.o] Error 1
make[3]: Leaving directory `/dpkg-1.10.27/build/lib'

With the attached patch 'dpkg' can be compiled
on amd64 using gcc-4.0.

The attached patch includes the patch from BTS bug #282669. This part has
already been applied to 'experimental' (thanks!).

Regards
Andreas Jochens

diff -urN ../tmp-orig/dpkg-1.10.27/include/parsedump.h ./include/parsedump.h
--- ../tmp-orig/dpkg-1.10.27/include/parsedump.h 2005-02-10 16:24:17.000000000 +0100
+++ ./include/parsedump.h 2005-03-15 22:34:39.544395106 +0100
@@ -30,7 +30,7 @@
   const char *canon;
 };

-extern const struct fieldinfo fieldinfos[];
+extern const struct fieldinfo *fieldinfos;
 extern const struct nickname nicknames[];
 extern const int nfields; /* = elements in fieldinfos, including the sentinels */

diff -urN ../tmp-orig/dpkg-1.10.27/lib/parse.c ./lib/parse.c
--- ../tmp-orig/dpkg-1.10.27/lib/parse.c 2005-02-10 16:24:17.000000000 +0100
+++ ./lib/parse.c 2005-03-15 22:34:59.432555170 +0100
@@ -39,7 +39,7 @@
 #include <sys/mman.h>
 #endif

-const struct fieldinfo fieldinfos[]= {
+const struct fieldinfo *fieldinfos= {
   /* NB: capitalisation of these strings is important. */
   { "Package", f_name, w_name },
   { "Essential", f_boolean, w_booleandefno, PKGIFPOFF(essential) },

diff -urN ../tmp-orig/dpkg-1.10.27/lib/mlib.c ./lib/mlib.c
--- ../tmp-orig/dpkg-1.10.27/lib/mlib.c 2005-02-10 16:24:17.000000000 +0100
+++ ./lib/mlib.c 2005-03-15 22:33:48.819188906 +0100
@@ -189,7 +189,7 @@
   switch(data->type) {
     case BUFFER_WRITE_BUF:
       memcpy(data->data.ptr, buf, length);
- (char*)data->data.ptr += length;
+ data->data.ptr ...

Message-ID: <email address hidden>
Date: Tue, 15 Mar 2005 17:48:32 -0600 (CST)
From: Adam Heath <email address hidden>
To: Andreas Jochens <email address hidden>, <email address hidden>
Subject: Re: Bug#299699: dpkg: FTBFS (amd64/gcc-4.0): array type has incomplete
 element type

tag 299699 - patch
thanks

On Tue, 15 Mar 2005, Andreas Jochens wrote:

> the latest version of gcc-4.0 is even more restrictive than the previous
> ones. There is a new error message 'array type has incomplete element type'
> for constructs like 'extern struct st x[];' when 'struct st' has not
> been defined.
>
> When building 'dpkg' on amd64 with gcc-4.0,
> I get the following error:
>
> gcc -g -O2 -Wall -Wwrite-strings -Wpointer-arith -Wimplicit -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wbad-function-cast -Wcast-qual -Wcast-align -Winline -Wmissing-noreturn -Wsign-compare -DHAVE_CONFIG_H -D_GNU_SOURCE -DLOCALEDIR=\"/usr/share/locale\" -I../../intl -I../intl -I../../include -I../.. -I../../lib -I../include -I.. -I. -I../../optlib -DUSE_ZLIB -DUSE_BZ2LIB -DCOPYINGFILE=\"/usr/share/doc/dpkg/copyright\" -c ../../lib/dump.c
> In file included from ../../lib/dump.c:37:
> ../../include/parsedump.h:33: error: array type has incomplete element type
> ../../lib/dump.c: In function 'w_charfield':
> ../../lib/dump.c:95: warning: cast discards qualifiers from pointer target type
> ../../lib/dump.c: In function 'w_booleandefno':
> ../../lib/dump.c:133: warning: cast discards qualifiers from pointer target type
> make[3]: *** [dump.o] Error 1
> make[3]: Leaving directory `/dpkg-1.10.27/build/lib'
>
> With the attached patch 'dpkg' can be compiled
> on amd64 using gcc-4.0.
>
> The attached patch includes the patch from BTS bug #282669. This part has
> already been applied to 'experimental' (thanks!).
>
> Regards
> Andreas Jochens

I don't agree with the patch; move the struct definition.

Message-ID: <email address hidden>
Date: Wed, 16 Mar 2005 08:19:36 +0100
From: Andreas Jochens <email address hidden>
To: Adam Heath <email address hidden>
Cc: Andreas Jochens <email address hidden>, <email address hidden>
Subject: Re: Bug#299699: dpkg: FTBFS (amd64/gcc-4.0): array type has incomplete element type

On 05-Mar-15 17:48, Adam Heath wrote:
> I don't agree with the patch; move the struct definition.

Hello,

thank you for your fast reply to my report.

Is the following patch OK?

Regards
Andreas Jochens

diff -urN ../tmp-orig/dpkg-1.10.27/include/parsedump.h ./include/parsedump.h
--- ../tmp-orig/dpkg-1.10.27/include/parsedump.h 2005-02-10 16:24:17.000000000 +0100
+++ ./include/parsedump.h 2005-03-16 08:05:05.291829783 +0100
@@ -30,7 +30,6 @@
   const char *canon;
 };

-extern const struct fieldinfo fieldinfos[];
 extern const struct nickname nicknames[];
 extern const int nfields; /* = elements in fieldinfos, including the sentinels */

@@ -68,6 +67,8 @@
   unsigned int integer;
 };

+extern const struct fieldinfo fieldinfos[];
+
 void parseerr(FILE *file, const char *filename, int lno, FILE *warnto, int *warncount,
               const struct pkginfo *pigp, int warnonly,
               const char *fmt, ...) PRINTFFORMAT(8,9);

Message-Id: <email address hidden>
Date: Wed, 16 Mar 2005 21:13:48 +0000
From: Scott James Remnant <email address hidden>
To: <email address hidden>, Adam Heath <email address hidden>
Cc: Andreas Jochens <email address hidden>
Subject: Re: Bug#299699: dpkg: FTBFS (amd64/gcc-4.0): array type has
 incomplete element type

--=-5lZDfOS506+d3eIl4dqP
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Tue, 2005-03-15 at 17:48 -0600, Adam Heath wrote:

> On Tue, 15 Mar 2005, Andreas Jochens wrote:
>=20
> > the latest version of gcc-4.0 is even more restrictive than the previou=
s
> > ones. There is a new error message 'array type has incomplete element t=
ype'
> > for constructs like 'extern struct st x[];' when 'struct st' has not
> > been defined.
> >
> > The attached patch includes the patch from BTS bug #282669. This part h=
as
> > already been applied to 'experimental' (thanks!).

> I don't agree with the patch; move the struct definition.
>=20
The fieldinfo struct definition includes members of a function typedef
which have struct fieldinfo pointers as arguments.

Moving the definition of the extern arrays to the bottom of the file
(while retaining the fieldinfo struct prototype at the top) is the right
solution.

Scott
--=20
Have you ever, ever felt like this?
Had strange things happen? Are you going round the twist?

--=-5lZDfOS506+d3eIl4dqP
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQBCOKGMIexP3IStZ2wRAvuyAKCTemwCadekvfsqhtng3jQzYGdEYwCeJk/u
wJkOxf4bTl6hJcjg7yxS0bI=
=8cdF
-----END PGP SIGNATURE-----

--=-5lZDfOS506+d3eIl4dqP--

Message-Id: <email address hidden>
Date: Wed, 16 Mar 2005 21:13:52 +0000
From: Scott James Remnant <email address hidden>
To: <email address hidden>
Subject: tagging 299699

# Automatically generated email from bts, devscripts version 2.8.6
tags 299699 pending

Message-Id: <email address hidden>
Date: Fri, 18 Mar 2005 16:32:28 +0000
From: Scott James Remnant <email address hidden>
To: <email address hidden>
Subject: tagging 299699

# Automatically generated email from bts, devscripts version 2.8.6
tags 299699 - pending

Message-Id: <email address hidden>
Date: Fri, 18 Mar 2005 11:47:13 -0500
From: Scott James Remnant <email address hidden>
To: <email address hidden>
Cc: Scott James Remnant <email address hidden>, Dpkg Development <email address hidden>
Subject: Fixed in upload of dpkg 1.13.2 to experimental

tag 136110 + fixed-in-experimental
tag 143882 + fixed-in-experimental
tag 164595 + fixed-in-experimental
tag 173205 + fixed-in-experimental
tag 184635 + fixed-in-experimental
tag 193877 + fixed-in-experimental
tag 223381 + fixed-in-experimental
tag 237684 + fixed-in-experimental
tag 253860 + fixed-in-experimental
tag 258608 + fixed-in-experimental
tag 261822 + fixed-in-experimental
tag 263743 + fixed-in-experimental
tag 264195 + fixed-in-experimental
tag 270241 + fixed-in-experimental
tag 277890 + fixed-in-experimental
tag 282790 + fixed-in-experimental
tag 284499 + fixed-in-experimental
tag 286632 + fixed-in-experimental
tag 287152 + fixed-in-experimental
tag 291816 + fixed-in-experimental
tag 296030 + fixed-in-experimental
tag 299090 + fixed-in-experimental
tag 299699 + fixed-in-experimental
tag 53376 + fixed-in-experimental
tag 6633 + fixed-in-experimental
tag 77109 + fixed-in-experimental
tag 92263 + fixed-in-experimental
tag 957 + fixed-in-experimental
tag 95755 + fixed-in-experimental

quit

This message was generated automatically in response to an
upload to the experimental distribution. The .changes file follows.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 18 Mar 2005 16:21:32 +0000
Source: dpkg
Binary: dpkg dselect dpkg-dev
Architecture: source i386 all
Version: 1.13.2
Distribution: experimental
Urgency: low
Maintainer: Dpkg Development <email address hidden>
Changed-By: Scott James Remnant <email address hidden>
Description:
 dpkg - Package maintenance system for Debian
 dpkg-dev - Package building tools for Debian
 dselect - a user tool to manage Debian packages
Closes: 957 6633 53376 77109 92263 95755 136110 143882 164595 173205 184635 193877 223381 237684 253860 258608 261822 263743 264195 270241 277890 282790 284499 286632 287152 291816 296030 299090 299699
Changes:
 dpkg (1.13.2) experimental; urgency=low
 .
   * md5sum has been removed, the coreutils or textutils version will be
     diverted to /usr/bin/md5sum. Closes: #6633, #136110.
     The following bugs are filed against the dpkg md5sum, so no longer apply.
     Closes: #95755, #193877, #223381, #264195, #270241, #286632,
   * Take Replaces into account when installing packages; don't issue a
     "trying to overwrite" error if the file that already exists is in
     a package that Replaces the one being installed.
     Closes: #164595, #184635, #277890.
   * Allow actions and status changes to be logged to a file. Disabled by
     default, uncomment line in /etc/dpkg/dpkg.cfg to enable.
     Closes: #957, #53376, #77109, #143882, #284499.
   * Don't truncate output of 'dpkg -l' when stdout is not a tty.
     Closes: #92263, #253860, #258608, #261822, #282790.
   * Fix further compilation problems with gcc 4.0. Closes: #299699
   * Handle tar files without trailing slash in directory names.
     Closes: #287152....

Message-ID: <email address hidden>
Date: Sun, 20 Mar 2005 14:33:18 +0000
From: Scott James Remnant <email address hidden>
To: <email address hidden>

tag 136110 - pending
tag 143882 - pending
tag 164595 - pending
tag 173205 - pending
tag 184635 - pending
tag 193877 - pending
tag 223381 - pending
tag 237684 - pending
tag 253860 - pending
tag 258608 - pending
tag 261822 - pending
tag 263743 - pending
tag 264195 - pending
tag 270241 - pending
tag 277890 - pending
tag 282790 - pending
tag 284499 - pending
tag 286632 - pending
tag 287152 - pending
tag 291816 - pending
tag 296030 - pending
tag 299090 - pending
tag 299699 - pending
tag 53376 - pending
tag 6633 - pending
tag 77109 - pending
tag 92263 - pending
tag 957 - pending
tag 95755 - pending

We can fix this by taking the experimental branch of dpkg, or back-porting the
patch.

fixed in 1.13.x