update-manager crashed with AttributeError in check_hovering(): 'tuple' object has no attribute 'get_tags'

This happens in the following function:

251 def check_hovering(self, x, y):
252 """Check if the mouse is above a tagged link and if yes show
253 a hand cursor"""
254 _hovering = False

I hovered over a link in the changelog for a package in update-manager without an issue. I'm using the Unity desktop environment and update-manager version 1:15.10.3.

Can you recreate this by viewing changelogs and hovering over links?

I can't see the Changes/Description panel - just a horizontal line. Might this happen when I hover over it and try to open it? Check out the screenshot.

It crashes as it finishes checking for updates.

It hasn't crashed today but the panel I mentioned at #4 (Changes / Description) opens just two lines of text when it should grow to occupy the space needed. Check out the screenshot.

Same error crash as it finishes checking for updates.

seems to affect me too

Getting this bug daily

The crash is in the following code:

    def check_hovering(self, x, y):
        """Check if the mouse is above a tagged link and if yes show
           a hand cursor"""
        _hovering = False
        # get the iter at the mouse position
        iter = self.get_iter_at_location(x, y)

        # set _hovering if the iter has the tag "url"
        tags = iter.get_tags()

The error is "AttributeError: '_ResultTuple' object has no attribute 'get_tags'".

self is an instance of a subclass of Gtk.TextView, which has a `get_iter_at_location()` method that returns a tuple (bool, iterator): http://lazka.github.io/pgi-docs/#Gtk-3.0/classes/TextView.html#Gtk.TextView.get_iter_at_location

(I'm guessing PyGTK used to return just the iterator (or None), but with the migration to PyGObject + gobject-introspection + GTK+ 3.x this changed.)

Suggested fix: iter = self.get_iter_at_location(x, y)

This buggy code pattern is also repeated in button_press_event.

Oops, I meant

  Suggested fix: iter = self.get_iter_at_location(x, y)[1]

but the [1] got lost somehow (accidental ^Z I bet).

Here's a patch that ought to fix this.

Steps to reproduce:

1. Open terminal
2. Run 'update-manager'
3. Wait for it to finish checking for updates

This bug results in the following error being printed to the terminal, possibly several times:

    Traceback (most recent call last):
      File "/usr/lib/python3/dist-packages/UpdateManager/ChangelogViewer.py", line 248, in visibility_notify_event
        self.check_hovering(bx, by)
      File "/usr/lib/python3/dist-packages/UpdateManager/ChangelogViewer.py", line 259, in check_hovering
        tags = iter.get_tags()
    AttributeError: '_ResultTuple' object has no attribute 'get_tags'

BTW the update-manager window does not disappear and continues to be functional, despite this error.

You have gtk 3.19 from a ppa, seems like the issue is that the function signature changed in that update ... the bug doesn't impact Ubuntu proper yet but is going to once gtk is updated, meanwhile that's an Ubuntu GNOME issue

The attachment "fix-lp1548425.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

Status changed to 'Confirmed' because the bug affects multiple users.

unsubscribing sponsors, the change is wrong for Ubuntu and concerns a ppa version of gtk

This bug was fixed in the package update-manager - 1:16.10.4

---------------
update-manager (1:16.10.4) yakkety; urgency=medium

  * ChangelogViewer: Fix an API call to work with GTK < and ≥ 3.20. Upstream
    gave gtk_text_view_get_iter_at_location a gboolean return type, which
    makes gobject-introspection return (return value, out parameter). (LP:
    #1548425)
  * ChangelogViewer: Set vexpand so that the changelog TextView takes up all
    the remaining vertical space.

 -- Iain Lane <email address hidden> Fri, 29 Jul 2016 11:15:54 +0100

This is still a problem in gnome 3.20

problem occurs daily.

manual restart of update-manger allows update-manager to function correctly.

I currently have version:

chris@localhost:~$ apt-cache policy update-manager
update-manager:
  Installed: 1:16.04.4
  Candidate: 1:16.04.4
  Version table:
 *** 1:16.04.4 500
        500 http://us.archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
        500 http://us.archive.ubuntu.com/ubuntu xenial-updates/main i386 Packages
        100 /var/lib/dpkg/status
     1:16.04.3 500
        500 http://us.archive.ubuntu.com/ubuntu xenial/main amd64 Packages
        500 http://us.archive.ubuntu.com/ubuntu xenial/main i386 Packages

with Gnome

chris@localhost:~$ apt-cache policy gdm3
gdm3:
  Installed: 3.20.1-1ubuntu2~ubuntu16.04.1
  Candidate: 3.20.1-1ubuntu2~ubuntu16.04.1
  Version table:
 *** 3.20.1-1ubuntu2~ubuntu16.04.1 500
        500 http://ppa.launchpad.net/gnome3-team/gnome3-staging/ubuntu xenial/main amd64 Packages
        100 /var/lib/dpkg/status
     3.18.3-0ubuntu2 500
        500 http://us.archive.ubuntu.com/ubuntu xenial/universe amd64 Packages

and got the software-updater crash a few minutes ago.

Additional info, actually update-manager doesn't crash as software-updater is still active.

This is still not fixed in 16.04.1 LTS apparently as it has just happened again and as I've said before update-manager doesn't actually crash AFAICT.

The reason this wasn't fixed in Ubuntu 16.04 is because it doesn't affect the proper Ubuntu archive, rather only users who have the gnome3 ppa enabled which provides a newer version of gtk. That being said given that there are tens of thousands of reports about this at the Error Tracker let's get this fixed.

Like I said several months ago..

"This is still a problem in gnome 3.20

problem occurs daily.

manual restart of update-manger allows update-manager to function..."

Hello Edson, or anyone else affected,

Accepted update-manager into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:16.04.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

I recreated this error by following the test case provided, I then installed python3-update-manager, update-manager and update-manager-core version 1:16.04.5 and no longer received the Traceback. Setting to verification-done.

This bug was fixed in the package update-manager - 1:16.04.5

---------------
update-manager (1:16.04.5) xenial; urgency=medium

  [ Iain Lane ]
  * ChangelogViewer: Fix an API call to work with GTK < and ≥ 3.20. Upstream
    gave gtk_text_view_get_iter_at_location a gboolean return type, which
    makes gobject-introspection return (return value, out parameter). (LP:
    #1548425)

 -- Brian Murray <email address hidden> Mon, 19 Dec 2016 13:46:30 -0800

The verification of the Stable Release Update for update-manager has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.