Improve documentation for the nil plugin
Bug #1549691 reported by
Björn Michaelsen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Snapcraft |
Fix Released
|
Medium
|
Kyle Fazzari | ||
Bug Description
The nil plugin doesnt even pull, while e.g. the make plugin will always execute "make" in the toplevel upstream dir. Thus there is not option to patch or prepare a custom makefile or something similar into the build.
Thus requesting the nil plugin should inherit the schema from super() to allow using snapcraft to get sources without replicating all in custom makefiles. Alternatively, provide a pull plugin doing this (so that it is just like nil -- except that it pulls).
Finally, if nil gets e.g. source-type and other stuff set which it does not have in its schema and ignores, it should error out and not silently ignore.
Revision history for this message
| Björn Michaelsen (bjoern-michaelsen) wrote | #1 |
Revision history for this message
| Sergio Schvezov (sergiusens) wrote | #2 |
| Changed in snapcraft: | |
| status: | New → Triaged |
| summary: |
- nil plugin should still pull + Improve documentation for the nil plugin |
| Changed in snapcraft: | |
| importance: | Undecided → Medium |
Revision history for this message
| Kyle Fazzari (kyrofa) wrote Re: nil plugin should support sources | #3 |
| summary: |
- Improve documentation for the nil plugin + nil plugin should support sources |
Revision history for this message
| Kyle Fazzari (kyrofa) wrote | #4 |
| summary: |
- nil plugin should support sources + Improve documentation for the nil plugin |
Revision history for this message
| Kyle Fazzari (kyrofa) wrote | #5 |
| Changed in snapcraft: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Kyle Fazzari (kyrofa) |
| milestone: | none → 2.8.1 |
| Changed in snapcraft: | |
| milestone: | 2.8.1 → none |
| Changed in snapcraft: | |
| milestone: | none → 2.8.3 |
| status: | In Progress → Fix Committed |
Revision history for this message
| Sergio Schvezov (sergiusens) wrote | #6 |
| Changed in snapcraft: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Also note that nil.py says "for example, have no source, but can still make use of all the properties available in snapcraft", while it explicitly has an empty properties set and thus ignores everything.