Fix for bug 1599771 breaks popup menus
Bug #1649577 reported by
Chris Coulson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Oxide |
Fix Released
|
Critical
|
Olivier Tilloy | ||
| 1.19 |
Fix Released
|
Critical
|
Olivier Tilloy | ||
Bug Description
Whilst trying to bring <select> popup menu support in to UbuntuWebView, I've been struggling to get them working. It turns out that popup menus are also broken in webbrowser-app with Oxide 1.19.
What's happening is:
1) The popup menu opens and receives focus.
2) Blink immediately requests that the popup menu closes because the webview sends a blur event.
This is a regression from bug 1599771. It sucks that we didn't find this sooner (when the UI lives in Oxide, this sort of thing will be easily testable with automated tests in Oxide).
I wonder whether we should revert the fix for bug 1599771 on the 1.19 branch and come up with a different fix for that.
Related branches
~santoshbit2007/oxide:focus_issue_refix
- Olivier Tilloy (community): Approve
- Chris Coulson: Approve
-
Diff: 167 lines (+103/-1)6 files modifiedqt/core/browser/oxide_qt_contents_view.cc (+4/-1)
qt/core/browser/oxide_qt_contents_view.h (+1/-0)
qt/core/glue/oxide_qt_contents_view_proxy.h (+1/-0)
qt/quick/oxide_qquick_contents_view.cc (+2/-0)
qt/tests/qmltests/core/tst_focus.html (+13/-0)
qt/tests/qmltests/core/tst_focus.qml (+82/-0)
| Changed in oxide: | |
| importance: | Undecided → Critical |
| status: | New → Triaged |
| milestone: | none → branch-1.20 |
Revision history for this message
| Olivier Tilloy (osomon) wrote | #1 |
| Changed in oxide: | |
| status: | Triaged → Fix Released |
| assignee: | nobody → Olivier Tilloy (osomon) |
Revision history for this message
| Olivier Tilloy (osomon) wrote | #2 |
To post a comment you must log in.
I can confirm this works in 1.18.5, and is broken in 1.19.5 and in trunk.