[canary] TPM is always selected as default

Bug #2033244 reported by Jean-Baptiste Lallement
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-desktop-installer
Fix Released
Critical
Unassigned
subiquity (Ubuntu)
Fix Released
Critical
Dan Bungert

Bug Description

Mantic 20230827

TPM FDE is always selected as default while, give it's experimental nature, it should be an opt-in feature.

Tags: fde
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :
Changed in subiquity (Ubuntu):
importance: Undecided → Critical
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I think the issue here is that the client is taking an arbitrary element of the "allowed" capabilities as the default:

    _storage.guidedCapability ??= _targets
        ?.whereType<GuidedStorageTargetReformat>()
        .expand((t) => t.allowed)
        .toSet()
        .firstOrNull;

It shouldn't do that.

Changed in ubuntu-desktop-installer:
importance: Undecided → Critical
status: New → Confirmed
Changed in subiquity (Ubuntu):
status: New → Confirmed
Dan Bungert (dbungert)
Changed in ubuntu-desktop-installer:
assignee: nobody → Dan Bungert (dbungert)
Revision history for this message
Dan Bungert (dbungert) wrote :

https://github.com/canonical/subiquity/pull/1774 seems to help, but as a set is used in u-d-i, the order is not certain to be preserved. Better to fix on u-d-i side.

Revision history for this message
Dan Bungert (dbungert) wrote (last edit ):

https://github.com/canonical/ubuntu-desktop-provision/pull/107 for the other side

root cause - in install-sources.yaml, enhanced-secureboot listed first, so the info objects were in that order, so we add the capability flags in that order, so the CORE_BOOT flag was there first.

fixed by:
subiquity - set it up so DIRECT is offered first, if it's going to be an option
u-d-i - drop the usage of a set - subiquity already is doing the same by checking if the flag is already in the list, so there should not be a redundant flag - then default to the first flag offered

Changed in ubuntu-desktop-installer:
assignee: Dan Bungert (dbungert) → nobody
Changed in subiquity (Ubuntu):
status: Confirmed → Fix Released
assignee: nobody → Dan Bungert (dbungert)
Changed in ubuntu-desktop-installer:
status: Confirmed → In Progress
Steve Langasek (vorlon)
Changed in ubuntu-desktop-installer:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.