External links should open in external web browser

Bug #224849 reported by Andrew Francis
88
This bug affects 17 people
Affects Status Importance Assigned to Milestone
Prism
Fix Released
Medium
prism (Ubuntu)
Triaged
Low
Micah Gersten

Bug Description

Binary package hint: prism-google-reader

I have 0.8+svn20071115r8030-0ubuntu3 on hardy. I've filed against prism-google-reader, but I have the same issue with prism-google-mail, and suspect this problem would be common to all prism-google-*.

I feel that external links within feed items (or, with gmail, links contained within email bodies) should open in the user's default web browser, rather than in a new window within the Prism instance.

Revision history for this message
ilia (ilia) wrote :

The same is on Jaunty. Looks like it contradicts one of the main Prism features.
Citing https://wiki.mozilla.org/Prism#Prism_.2F_SSB_Objectives
Open external links in real browser: If I click a link in the webapp that opens a new site, don’t change my webapp browser window. Open all external links in my default/real browser.

Revision history for this message
Christian Ide (cide) wrote :

On my Jaunty system the prism-google-mail app works as expected. External links open in the "real" firefox. But in Karmic external links open in a new prism window.

Revision history for this message
In , Matthew-gertner (matthew-gertner) wrote :

Normally clicking on a link to a URL that is not in the same base domain as the webapp URL should cause the page to be opened in the default browser, not in Prism. This works in the main webapp windows, but in a popup window, the link is not detected as external. This means it is opened erroneously in Prism instead of the default browser.

Revision history for this message
In , Matthew-gertner (matthew-gertner) wrote :

Created an attachment (id=438979)
Add progress listener for popups as well so that click/activate handlers are set

Revision history for this message
In , Matthew-gertner (matthew-gertner) wrote :

Sending chrome/content/webrunner.js
Transmitting file data .
Committed revision 65960.

Revision history for this message
In , Matthew-gertner (matthew-gertner) wrote :

When external links are specified using a non-anchor tag (e.g. <area>) they are always opened in Prism. If they are external they should open in the default browser.

Revision history for this message
In , Matthew-gertner (matthew-gertner) wrote :

Created attachment 439197
Treat any tag with an href attribute as a link

Revision history for this message
In , Matthew-gertner (matthew-gertner) wrote :

Sending chrome/content/webrunner.js
Transmitting file data .
Committed revision 66714.

Revision history for this message
Olivier Bilodeau (plaxx) wrote :

I'm bitten by this also in Lucid.

What's strange is that webapp.ini include or exclude parameters don't change anything at all. I quickly checked the mozilla-labs-prism google group and found nothing about this. I'll keep looking for a bit.

Revision history for this message
Hilton Shumway (hillshum) wrote :

I'm dealing with this in Lucid as well

Changed in prism (Ubuntu):
status: New → Confirmed
Revision history for this message
permanuno (permanuno) wrote :

I'm experiencing the same in Lucid.

$ xulrunner --version
Mozilla XULRunner 1.9.2.3 - 20100414003610
$ prism --version
 Prism 1.0b3
$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=10.04
DISTRIB_CODENAME=lucid
DISTRIB_DESCRIPTION="Ubuntu 10.04 LTS"
$ dpkg-query -W xulrunner* prism*
prism 1.0b3+svn20100210r62050-0ubuntu1
xulrunner-1.9
xulrunner-1.9.2 1.9.2.3+nobinonly-0ubuntu2

Revision history for this message
Micah Gersten (micahg) wrote :

Thank you for reporting this to Ubuntu. This has actually been fixed upstream already. I will add the bug number later tonight. Please report any other bugs you may find.

Changed in prism (Ubuntu):
assignee: nobody → Micah Gersten (micahg)
importance: Undecided → Low
status: Confirmed → Triaged
Changed in prism:
status: Unknown → Fix Released
Revision history for this message
Olivier Bilodeau (plaxx) wrote :

@Micah, the upstream bug suggests that it's external links inside prism popups that aren't opened using the default system browser. However, every external link I click open in the main prism window instead of the default browser.

Revision history for this message
Micah Gersten (micahg) wrote :

@Olivier Bilodeau
You are correct. This is actually working for me on Lucid. Could you give an example of this issue?

Revision history for this message
Olivier Bilodeau (plaxx) wrote :

The attached screenshot is my prism window before opening a link. Note that I delete my .prism/gmail/<profile>/compatibility.ini before each prism launch with a script to workaround bug #518422.

Revision history for this message
Olivier Bilodeau (plaxx) wrote :

On this screenshot, I clicked on a link in the email: this bug's link. Instead of opening in the default browser, it opened in a prism popup even though it is nothing like *google.com.

Revision history for this message
Olivier Bilodeau (plaxx) wrote :

This time, I clicked on the ad link in the blue bar. Instead of opening a popup, it opened in the prism main window. The most annoying thing is that this is what happens with links in chat windows too.

Strangely, the title bar is still gmail's.

I am willing to test further, the only thing is that I'll need instructions as I am not familiar with tracing / debugging a xul app.

Revision history for this message
Ray DeCampo (rdecampo) wrote :

I am experiencing the same issue on a 10.4 system that is up to date as of today (2010/05/24). If there is anything I can do to debug, etc., please let me know.

Revision history for this message
Rockroehre (rockroehre) wrote :

Hi there,

I have the same thing on lucid, using prism-google-mail. I've been using it on karmic before and don't recall this behaviour. On karmic, external links always used to open in firefox, like I would like them to. Anything I can do to help, please let me know.

Revision history for this message
Micah Gersten (micahg) wrote :

Sorry, I think I found the correct upstream this time.

Changed in prism:
status: Fix Released → Unknown
Changed in prism:
status: Unknown → Fix Released
Revision history for this message
Olivier Bilodeau (plaxx) wrote : Re: [Bug 224849] Re: External links should open in external web browser

@Micah

Sorry, I think I found the correct upstream this time.
>

I just inspected the source for gmail (which is most links I click in prism
demonstrating the wrong behavior) and the html looks like:

<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=559524"
target="_blank">https://bugzilla.mozilla.org/<wbr>show_bug.cgi?id=559524</a>

So this upstream bug is not covering this issue (for me atleast).

Oh and gmail's html is all generated by javascript so I don't know if this
has impact..

Revision history for this message
dimitrij (chekout) wrote :

I have installed Prism today on lucid, this bug is still present for me.

'mailto:' links seem to work fine.

Anybody with a better solution than dragging links to firefox?

Revision history for this message
permanuno (permanuno) wrote :

@dimitrij, I installed Mozilla's version in my home directory and it doesn't have the bug. Download the standalone version from http://prism.mozillalabs.com/. Untar and bunzip2 the downloaded file somewhere in your home dir (I went with ~/opt/prism). Then download the attached script and run it to execute the prism in your home dir.

Revision history for this message
LordPhoenix (lorphoenix) wrote :

I have same problem with prism-google-reader on Ubuntu maverick beta.
prism package version is 1.0b3+svn20100210r62050-0ubuntu1

Changed in prism:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.