gnome-session-save presents a gui always

Bug #30384 reported by Timo Aaltonen
8
Affects Status Importance Assigned to Milestone
gnome-session
Fix Released
High
gnome-session (Ubuntu)
Fix Released
Wishlist
Ubuntu Desktop Bugs

Bug Description

http://bugzilla.gnome.org/show_bug.cgi?id=149447

I've tried to contact upstream directly without success. Could this be applied for dapper? The feature is harmless, but very useful.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the bug/patch. I'll have a look on it. What is the pach useful for? The API has some parameter to not open the dialog when login out if you want to that can be used by applications which want to use it

Changed in gnome-session:
status: Unconfirmed → Confirmed
assignee: nobody → desktop-bugs
status: Unconfirmed → Confirmed
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Gnome-screensaver has support for a "logout" button that is displayed on the lock-dialog after a preset time (logout_delay), like XLock had.

It is useful for public workstations for example in classrooms where users are allowed to lock the session for a short time if they need to go to the bathroom etc. but still allowing other users (and admins!) to logout a locked session after the time has expired. Opening another session doesn't work, because the previous one is left hanging in the background.

If there really is a way to close the session nicely without applying the patch, I'd like to know ;) The man page isn't that helpful. (the gui is always presented, whether you have --gui option or not?)

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

ok, the upstream bug now has a simple patch which makes g-s-s open a gui only when --gui option is given.

So, now I'd be able to use g-s-s --kill with gnome-screensaver, and our support staff would be happy (easier to logout locked sessions, if there were any)

Revision history for this message
Sebastien Bacher (seb128) wrote :

This upload fixes the issue:

 gnome-session (2.14.1-0ubuntu1) dapper; urgency=low
 .
   * Sync with Debian
   * New upstream version:
     Session Manager
     - Share one GConfClient
     - Plug leaks
   * debian/control.in:
     - Build-Depends on sharutils
     - don't Build-Depends on sng
     - don't Recommends desktop-base
     - updated the debhelper version for Ubuntu
   * debian/gconf-defaults:
     - use the Ubuntu splash
   * debian/gnome-session.install:
     - don't install the Debian sng
   * debian/gnome-wm:
     - fix for openbox.
   * debian/patches/01_fix_autostart_edition.patch:
     - patch from Vincent Untz, fix the autostart edition
   * debian/patches/02_no_warning_crash.patch:
     - don't crash on warning, users expect stability
   * debian/patches/03_powermanagement.diff:
     - powermanagement features.
   * debian/patches/06_silent_option.patch:
     - define a --silent option,
       patch from http://bugzilla.gnome.org/show_bug.cgi?id=149447
       (Ubuntu: #30384)
   * debian/patches/07_kill_esd.patch:
     - updated
   * debian/patches/08_menu-change.diff:
     - the session options are in "Desktop Preferences".
   * debian/patches/09_splash_hide.diff:
     - fix some issue with splashscreen staying on screen when not needed.
   * debian/patches/10_update_notifier:
     - added update-notifier to the list of known applications
       (closes ubuntu #9316)
   * debian/patches/11_session_dialog.patch:
     - new session dialog by Manu Cornet <email address hidden>
   * debian/patches/12_shaped_splash.patch:
     - shape for splash
   * debian/patches/13_smoother_fading.patch:
     - updated patch from http://bugzilla.gnome.org/show_bug.cgi?id=140717
   * debian/pixmaps:
     - icons for the new dialog, by Manu Cornet <email address hidden>
   * debian/rules:
     - don't use sng
     - install the icons for the new dialog

I've used the upstream patch with the --silent option, your suggestion was changing the default behaviour which breaks application expecting it

Changed in gnome-session:
status: Confirmed → Fix Released
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

I thought that the actual fix I presented upstream would've been better than applying the original patch.. Now it still presents a gui even if you don't add a "--gui" option. But anyway this is better than nothing, and lets see what upstream does.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Did you read my previous comment? Your way break compatibility and application expecting the current behaviour

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

hmm, no I didn't :)

anyway, as nothing in Gnome uses gnome-session-save anyway anymore (?), I thought that "breaking" it didn't matter.

Revision history for this message
Sebastien Bacher (seb128) wrote :

maybe some other applications use it, maybe some administrators have pieces of shell batch using it, etc

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

well, they are broken as well then, and adding --gui would fix them. Admins are wise, they can read the man-page. Don't know about application hackers ;)

Revision history for this message
Sebastien Bacher (seb128) wrote :

breaking compatibility is not nice, anyway we have bugs to fix I stop discussing on that one now

Changed in gnome-session:
status: Unconfirmed → Confirmed
Changed in gnome-session:
status: Confirmed → Fix Released
Changed in gnome-session:
importance: Unknown → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.