blueproximity calls the proximity command twice each interval

Forwarded upstream here: https://sourceforge.net/tracker/?func=detail&aid=2788125&group_id=203022&atid=983922

@jsalvata:
could you explain what the patch modifies and for which reason? I may recheck the patch then so I might include it upstream. I am at work now, so I don't have my development environment here with me.

@jsalvata:
oh, and could you tell me in what environment this error popped up? were you checking presence of multiple devices? I'd like to reproduce that bug later at home.

The problem (which is minor) will happen on any environment, even with only
one device. Detailed steps to reproduce are in the bug report -- no special
configurations needed as far as I can tell.

The code seemed to have two or three places where the proximity command was
handled... I just shuffled the existing code around a little to put
everything in the proximityCommand and go_proximity methods without
repetitions. Check the patch -- the new code is shorter than the old, so it
shouldn't be difficult to follow.

--
Jordi Salvat i Alabart

On Tue, May 12, 2009 at 5:32 PM, Lars Friedrichs <email address hidden>wrote:

> @jsalvata:
> oh, and could you tell me in what environment this error popped up? were
> you checking presence of multiple devices? I'd like to reproduce that bug
> later at home.
>
> --
> blueproximity calls the proximity command twice each interval
> https://bugs.launchpa <https://bugs.launchpad.net/bugs/313040>
>
> --
> Jordi Salvat i Alabart
> CTO & Project Manager
> Salir.com
> +34 676 49 86 00
> d.net/bugs/313040 <https://bugs.launchpad.net/bugs/313040>
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in BlueProximity: New
> Status in “blueproximity” source package in Ubuntu: New
>
> Bug description:
> Binary package hint: blueproximity
>
> While investigating an unrelated issue, I found that blueproximity calls
> the proximity command twice as often as configured.
>
> Steps to reproduce:
> - In Preferences > Locking enter this "Proximity command:"
> date>>/tmp/proximity-runs.log
> - Set the Command Interval to a small value (e.g. 60 seconds)
> - Watch that log file
>
> I would expect to see a timestamp every ~50 seconds... instead I see two.
> Here's my specific result:
>
> Fri Jan 2 01:52:07 CET 2009
> Fri Jan 2 01:52:25 CET 2009
> Fri Jan 2 01:53:07 CET 2009
> Fri Jan 2 01:53:25 CET 2009
> Fri Jan 2 01:54:08 CET 2009
> Fri Jan 2 01:54:24 CET 2009
> Fri Jan 2 01:55:08 CET 2009
>