gPass Glade Files Major Improvements

Bug #313808 reported by Andrew
8
Affects Status Importance Assigned to Milestone
gpass (Ubuntu)
Invalid
Wishlist
Unassigned

Bug Description

Binary package hint: gpass

The gPass Glade files (located in /usr/share/gpass) use an old glade file format, I have corrected this by putting them all through glade-3 (with gnome support). Also it uses inefficient methods, like using a button that has a container, containg an image an a label, when simply a GTK Stock Button can be used.

They also have some confusing passages of text, which I have corrected to be more easily understandable.

Finally, they don't use GTK Stock icons in most cases, instead opting for Gnome Stock Icons, which then don't chnage with the current GTK Theme, again I have changed this.

I have attached a patch that solves all of these issues that needs to be applied to the '/usr/share/gpass' folder. I have tested everything and it all works.

I would be very happy if someone could update the package for this.

Revision history for this message
Andrew (and471) wrote :

Here is a debdiff for Jaunty, which includes the changes specified above, but also has some changes in the source code files which makes them use gtk stock icons over gnome stock icons.

Andrew (and471)
Changed in gpass:
status: New → Fix Committed
Revision history for this message
Daniel Holbach (dholbach) wrote :

Can you please forward the change upstream? The change is rather large and very hard to maintain if upstream changes.

Changed in gpass:
status: Fix Committed → Confirmed
Revision history for this message
Martin Olsson (mnemo) wrote :

The upstream bug track is a 404 broken link, and the last release was 2006-03-25 according to the upstream homepage:
http://projects.netlab.jp/gpass/

I have sent an e-mail to the author asking about the status and giving the URL to this bug report.

Iain Lane (laney)
summary: - gPass Glade Files Major Improvements
+ [karmic] gPass Glade Files Major Improvements
Revision history for this message
Sebastien Bacher (seb128) wrote : Re: [karmic] gPass Glade Files Major Improvements

could you send the change to upstream and debian? doesn't seem the sort of changes we want to keep in a distribution specific way

Changed in gpass (Ubuntu):
importance: Undecided → Wishlist
summary: - [karmic] gPass Glade Files Major Improvements
+ gPass Glade Files Major Improvements
Revision history for this message
Benjamin Drung (bdrung) wrote :

Martin, did you get a response from the upstream author? Will your patch be accepted?

Please forward your patch to Debian. It's better to have your patch in Debian and Ubuntu instead of Ubuntu alone. When your patch is accepted by the Debian maintainer, it will be automatically synced to Ubuntu. I unsubscribe ubuntu-universe-sponsors for now. Please resubscribe the us, when the Debian maintainer does not respond to your bug report.

Revision history for this message
Phillip Susi (psusi) wrote :

The gpass package has been removed from Ubuntu. Closing all related bugs.

Changed in gpass (Ubuntu):
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.