sleep shortcut belongs to gnome-power-manager

Oh, and gnome-settings-daemon shouldn't attempt to respond to it either

What about "hibernate"? And what about people not using gnome-power-management? I think that those actions should stay to gnome-control-center, is there any real need to move it to gnome-power-manager?

Hibernate belongs to gnome-power-manager too

Well, gnome-power-manager handles the sleep and suspend actions (invoking hal as appropriate) and if (as I did for a while) you happen to have a shortcut in gnome-control-center too, then you get a double suspend which is very very annoying and confusing for the user.

Perhaps leave the functionality there but remove the shortcuts and ensure they default to disabled?

I thought gnome-power-manager was part of ubuntu-desktop now, in which case we can expect it to handle the events.

Yes, just dropping support for these in control-center is the right thing to do - they're handled via HAL and gnome-power-manager now.

debdiff

Ok, this is pretty much identical to my patch. Seb, can we have one of them added?

I'm working on that now. Should we also use the patch from http://bugzilla.gnome.org/show_bug.cgi?id=339857 or is that a feature for the next cycle?

Not at the moment - I've just disabled the brightness handling code in
gnome-power-manager because it's slightly broken on some of the systems
we'll support. I'll be working on that over this weekend - if it works,
then that would be a sensible thing to add.

--
Matthew Garrett | <email address hidden>

Thank you for the patch Daniel, I've used it for this upload which fixes the issue:

 control-center (1:2.14.1-0ubuntu8) dapper; urgency=low
 .
   * debian/patches/90_from_cvs_fix_potential_overrun.patch:
     - patch from CVS, fix potential overrun when swapping buttons for the mouse
       (GNOME: #338254)
   * debian/patches/91_from_cvs_fix_missing_prototype.patch:
     - patch from CVS, fix missing protype (possible crasher) (GNOME: #338849)
 .
   [ Daniel Holbach ]
   * debian/patches/07_default_keys.patch:
     - remove change to power- and sleep-key.
   * debian/patches/11_sleepkey.patch:
     - dropped.
   * debian/patches/27_remove_hibernation_and_sleeping.patch:
     - remove power and sleep capabilities.
   * This was all done to fix Malone: #32126 and reduce the possibility of
     double suspends, or two applications trying to catch a call.

As part of an energy (environment) saving drive, I have migrated to Ubuntu dapper from sarge on my main machine mainly because there is better support for suspend and hibernate. Sadly, the (newer) unbranded keyboards which feature power keys are of poor quality; I can't get on with them. Many newer keyboards also still lack power buttons.

Given that BIOSes often allow an alias to the wake-up button (ctrl+Fx), there is no need for the power buttons so long as the OS can respond to some other key combination to put the machine in a user-configurable power saving state.

In gnome power management->general, the sleep button can be configured to suspend the machine. I need to be able to set some other key combination as an alias for the sleep button. Perhaps configure ctrl+Fx to put the machine into suspend mode.

It is a bug for the desktop infrastructure to handle keyboard events for suspend and hibernate.

Users of all desktops and users of console will want consistent power saving keyboard shortcuts.

The desktop environment should just write the settings to a config file and let a script make changes to the system on boot-up or on settings change.