/people/+peoplelist is blank

Bug #37310 reported by Stuart Bishop
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Christian Reis

Bug Description

https://launchpad.net/people/+peoplelist now contains noting but lots of
invisible, empty anchor tags.

 affects /products/launchpad

--
Stuart Bishop <email address hidden> http://www.canonical.com/
Canonical Ltd. http://www.ubuntu.com/

Revision history for this message
Christian Reis (kiko) wrote :

The code there is on crack; it's doing

        <a tal:condition="not: person/browsername"
           tal:content="person/browsername"
           tal:attributes="href person/name" />

However, I'm not sure why browsername is not working.

Changed in launchpad:
assignee: nobody → kiko
status: Unconfirmed → Confirmed
Revision history for this message
Christian Reis (kiko) wrote :

Landed; also took the liberty of updating the navigation links.

Note, however, Stuart, that the users in the list have NULL displaynames; for instance:

  https://launchpad.net/people/benno

The page was changed to cope with it but the other Person pages may not cope so well; should we update displayname = name when displayname is NULL?

Changed in launchpad:
status: Confirmed → Fix Committed
Revision history for this message
Stuart Bishop (stub) wrote : Re: [Bug 37310] Re: /people/+peoplelist is blank

Christian Reis wrote:
> Landed; also took the liberty of updating the navigation links.
>
> Note, however, Stuart, that the users in the list have NULL displaynames; for instance:
>
> https://launchpad.net/people/benno

There are 140 people with the empty string as their displayname. I've reset
these displaynames, setting the field to the same as their name field. I
don't think it is possible to set names to the empty string any more via the
UI. I'm adding a constraint to Person.displayname ensuring that it can't be
the empty string or contain nothing but whitespace.

displayname is NOT NULL, and we need to ensure

> The page was changed to cope with it but the other Person pages may not cope so well; should we update displayname = name when displayname is NULL?

There isn't much we an do about the remaining pathalogical cases where you
can create an invisible displayname (or nearly so) - its just a side effect
of using Unicode.

--
Stuart Bishop <email address hidden> http://www.canonical.com/
Canonical Ltd. http://www.ubuntu.com/

Christian Reis (kiko)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.