Launchpad itself

supermirror branch puller does not preserve source branch format

Bug #44183 reported by David Allouche
6
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Andrew Bennetts

Bug Description

The branch puller creates a target branch with bzrlib.bzrdir.BzrDir.create_branch_convenience(location, force_new_repo=True, force_new_tree=False) and disregard the formats of the source branch.

The branch puller should create a target branch using the same branch format(s) as the source branch, to preserve the user's data and avoid knits<->weaves conversions.

Tags: lp-code
Revision history for this message
David Allouche (ddaa) wrote :

Also related to bug 44182 (supermirror branch puller leaves empty branch when initial mirroring fails). If the branch puller tried to access the source branch before creating the target, it would not leave empty branches when the source cannot be accessed.

Changed in launchpad-bazaar:
status: Unconfirmed → Rejected
status: Rejected → Confirmed
Revision history for this message
David Allouche (ddaa) wrote :

That should be fixed quickly, or when we rollout the new bzrlib, new knit branches will be mirrored as weave, which is a bad thing.

Also related to bug 41414.

David Allouche (ddaa)
Changed in launchpad-bazaar:
assignee: nobody → spiv
Revision history for this message
Andrew Bennetts (spiv) wrote :

Actually, according to the test cases I've written, the situation is slightly different. It does ignore source format, but rather than defaulting to weaves, bzr 0.8 will default to knits. So new knit branches will be mirrored as knits, like we want. The only problem then is that new weave branches will also be mirrored as knits.

Given that new branches are likely be knits, or likely to be soon upgraded to knits, I don't think we need to panic.

Revision history for this message
David Allouche (ddaa) wrote :

Right, I got too worried.

Still, that blocks and aggravates bug 41414.

Revision history for this message
Andrew Bennetts (spiv) wrote :

Fix committed to rocketfuel r3618.

Changed in launchpad-bazaar:
status: Confirmed → Fix Committed
Andrew Bennetts (spiv)
Changed in launchpad-bazaar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.