Inline assembler fix needed for libmad in Lucid on armel

Bug #489242 reported by Dave Martin
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libmad (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Some inline assembler in libmad uses some instruction operand combinations (specifically the RSB isntruction) which are not permitted in Thumb-2, causing a build failure.

See the following:

http://linux.onarm.com/bugzilla/show_bug?id=36
patch: http://linux.onarm.com/bugzilla/attachment.cgi?id=11

I have tested that it builds, assuming that https://bugs.launchpad.net/ubuntu/+bug/488302 is also fixed.

If anyone can suggest a good test to check it runs properly I'm happy to have a go. I believe this patch has been tested in the context of the ARM Linux Internet Platform (http://linux.onarm.com/), but not in the Ubuntu context.

Revision history for this message
Dave Martin (dave-martin-arm) wrote :

Note that the referenced patch should be upstreamed in the meantime, but it is not upstream yet.

Revision history for this message
Loïc Minier (lool) wrote :

Dave, the current package has a slightly different patch, see debian/patches/Provide-Thumb-2-alternative-code-for-MAD_F_MLN.diff. Could you check which one we want to keep?

There's also debian/patches/libmad.thumb.diff which seems related.

I'm not sure which patch should be upstreamed, nor whether this bug is still valid, but someone reported audio corruption in bug #587632.

Loïc Minier (lool)
tags: added: thumb
Steve Langasek (vorlon)
tags: added: arm-porting-queue
Jani Monoses (jani)
Changed in libmad (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.