Timezone 5.0.7 windows

Bug #531979 reported by Bruno Hostalery
40
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Odoo GTK Client (MOVED TO GITHUB)
Fix Released
Critical
Stephane Wirtel (OpenERP)
Nominated for 5.0 by Numérigraphe

Bug Description

When using client windows 5.0.7, and timezone set to the user, warning show :

The "pytz" Python library is missing!
Time values will be displayed as if located in the server timezone.

Related branches

Revision history for this message
Numérigraphe (numerigraphe) wrote :

Marking Bug #531980 a duplicate - we reported this the same time.

Changed in openobject-client:
status: New → Confirmed
Revision history for this message
Numérigraphe (numerigraphe) wrote :

Will there be a fix for 5.0.7 or will it only be fixed in 5.0.8?
Lionel

Revision history for this message
Numérigraphe (numerigraphe) wrote :

Workaround: remove the users' time zones (you'll have to enter it again when this is fixed)
    update res_users set context_tz =null;
Lionel

Revision history for this message
Bruno Hostalery (istf) wrote :

This other, seems to work but must be more testing is to :
    install 5.0.6 version,
    copy library.zip
    install 5.0.7 version
    extract from library.zip v 5.0.6 pytz directory
    delete from library.zip v5.0.7 pytz directory
    insert into library.zip pytz v 5.0.6 directory

Just a remark. I try to unzip both library, copy between directory,k and rezip it, and that doesn't work (i don't understand why)
But with explorer, without unzipping library, just enter in it and drag adn drop library, no warning when running 5.0.7 client.

Have a nice day and good tests

Revision history for this message
Bruno Hostalery (istf) wrote :

Damage that for a software which wants to be international and professionnal no language and timezone patch is online in download section.
Well done for test and develop 5.2 branch, but stable version is incomplete.

Changed in openobject-client:
milestone: none → 5.0.8
assignee: nobody → Stephane (Open ERP) (stephane-openerp)
importance: Undecided → High
Changed in openobject-client:
assignee: Stephane (Open ERP) (stephane-openerp) → Olivier Dony (OpenERP) (odo)
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Stephane, reassigning to you, seems that this really is a packaging issue for Client 5.0.7. Basically using the library.zip in client-5.0.7 you can't do 'import pytz' anymore, and you can also see that the zoneinfo directory is missing, now if you replace the whole pytz module with the pytz module from 5.0.6 or the one in the pytz-2010b-py2.5.egg from the web-5.0.7 it works.

Could you double-check the windows packaging procedures and make sure that they are deterministic? How come we have different pytz modules in web and client, or between 5.0.6 and 5.0.7?

And by the way, why does one of them use a site-packages python deployment structure while the other has a library.zip version without sources?

Changed in openobject-client:
assignee: Olivier Dony (OpenERP) (odo) → Stephane (Open ERP) (stephane-openerp)
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

BTW everyone, you don't need to use SQL if your user has a timezone set and you want to remove it temporarily: it is possible to unset the timezone using the User Preferences in the Web client (not in GTK).

 I will add a backlog item to make this consistent.

Revision history for this message
Stephane Wirtel (OpenERP) (stephane-openerp) wrote :

Hi all,

I uploaded a beta of the client 5.0.8, can you check and tell me if the issue is still valid.

http://openerp.com/download/unstable/win32/openerp-client-setup-5.0.8beta1.exe

Thanks

Changed in openobject-client:
importance: High → Critical
status: Confirmed → In Progress
Revision history for this message
Stephane Wirtel (OpenERP) (stephane-openerp) wrote :

I uploaded this branch for a code review:

Branch: https://code.launchpad.net/~stephane-openerp/openobject-client/fix_timezone_pytz
Windows Installer: http://openerp.com/download/unstable/win32/openerp-client-setup-5.0.8.dev1055.exe

I will ask to the code reviewer to check the bugfix

Revision history for this message
Stephane Wirtel (OpenERP) (stephane-openerp) wrote :

I had a feedback and the last client has a bug with the timezone :/

Don't use it,

Stephane

Revision history for this message
Stephane Wirtel (OpenERP) (stephane-openerp) wrote :

I pushed a new version of my Windows Installer for this bugfix

Branch: https://code.launchpad.net/~stephane-openerp/openobject-client/fix_timezone_pytz
Windows Installer: http://openerp.com/download/unstable/win32/openerp-client-setup-5.0.8.dev1056.exe

Please report,

Thanks

Revision history for this message
Numérigraphe (numerigraphe) wrote :

Stéphane,
I still meet this problem using openerp-client-setup-5.0.8.dev1056.exe, sorry.
Lionel

Revision history for this message
Stephane Wirtel (OpenERP) (stephane-openerp) wrote :

I know, I just fixed the packaging process.

I'm uploading a new version of the client and I checked the zoneinfo directory from pytz-2010, I think it's fixed.

Revision history for this message
Stephane Wirtel (OpenERP) (stephane-openerp) wrote :
Changed in openobject-client:
status: In Progress → Fix Released
Revision history for this message
Numérigraphe (numerigraphe) wrote :

Stéphane,
This version fixed this issue on my setup. Thanks.
You marked the bug with "fix released" - do you advise we use this version in production, or should we wait for 5.0.8?
Lionel

Revision history for this message
Stephane Wirtel (OpenERP) (stephane-openerp) wrote :

This version is not the official, it's a test to be sure that we have removed the bug with the pytz package.

The official 5.0.8 is still planned for the next week (April 1st).

Revision history for this message
Stephane Wirtel (OpenERP) (stephane-openerp) wrote :

And the bug was in the packaging process (on my Windows box).

Revision history for this message
Sebastien LANGE - http://www.Syleam.fr (alnslang) wrote :

Stéphane,

I just tested it and it's ok for me.

Many thanks.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.