DBus Menu

GObject Introspection detection broken

Bug #552538 reported by Dennis Schridde on 2010-03-31

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	DBus Menu	Fix Released	Low	Ted Gould	DBus Menu 0.4.94
	Unity Foundations	Fix Released	Low	Ted Gould	Unity Foundations oneiric-beta-2

Bug Description

configure.ac checks: GOBJECT_INTROSPECTION_CHECK([0.6.3])
But this macro does not exist if GObject Introspection is not installed.
I had to manually replace it with: AM_CONDITIONAL([HAVE_INTROSPECTION], [false])

Related branches

lp:~dbusmenu-team/libdbusmenu/ubuntu

Rejected for merging into lp:~ubuntu-desktop/libdbusmenu/ubuntu

Ken VanDine: Disapprove on 2011-10-13

Superseded for merging into lp:libdbusmenu/0.5

Ken VanDine: Pending requested 2011-01-27

Diff: 67319 lines (+66205/-527)

110 files modified

.bzrignore (+0/-229)
AUTHORS (+17/-0)
ChangeLog (+5918/-0)
Makefile.in (+821/-0)
aclocal.m4 (+10063/-0)
autogen.sh (+0/-12)
compile (+143/-0)
config.guess (+1502/-0)
config.h.in (+86/-0)
config.sub (+1714/-0)
configure (+16483/-0)
debian/changelog (+657/-0)
debian/control (+225/-0)
debian/copyright (+40/-0)
debian/gir1.2-dbusmenu-glib-0.4.install (+1/-0)
debian/gir1.2-dbusmenu-gtk-0.4.install (+1/-0)
debian/gir1.2-dbusmenu-gtk3-0.4.install (+1/-0)
debian/libdbusmenu-glib-dev.install (+6/-0)
debian/libdbusmenu-glib-doc.install (+1/-0)
debian/libdbusmenu-glib3.install (+1/-0)
debian/libdbusmenu-gtk-dev.install (+6/-0)
debian/libdbusmenu-gtk-doc.install (+1/-0)
debian/libdbusmenu-gtk3-3.install (+1/-0)
debian/libdbusmenu-gtk3-dev.install (+5/-0)
debian/libdbusmenu-gtk3.install (+1/-0)
debian/libdbusmenu-jsonloader-dev.install (+4/-0)
debian/libdbusmenu-jsonloader3.install (+1/-0)
debian/libdbusmenu-tools.install (+3/-0)
debian/rules (+45/-0)
debian/source/format (+1/-0)
debian/watch (+2/-0)
depcomp (+630/-0)
docs/Makefile.in (+613/-0)
docs/libdbusmenu-glib/Makefile.in (+613/-0)
docs/libdbusmenu-glib/reference/Makefile.in (+689/-0)
docs/libdbusmenu-glib/reference/html/annotation-glossary.html (+71/-0)
docs/libdbusmenu-glib/reference/html/api-index-full.html (+406/-0)
docs/libdbusmenu-glib/reference/html/ch01.html (+48/-0)
docs/libdbusmenu-glib/reference/html/index.html (+46/-0)
docs/libdbusmenu-glib/reference/html/index.sgml (+120/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuClient.html (+427/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuClientMenuitem.html (+92/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuMenuitem.html (+1326/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuMenuitemProxy.html (+154/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuServer.html (+260/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib.devhelp (+109/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib.devhelp2 (+109/-0)
docs/libdbusmenu-glib/reference/html/object-tree.html (+32/-0)
docs/libdbusmenu-glib/reference/html/style.css (+266/-0)
docs/libdbusmenu-glib/reference/tmpl/client-menuitem.sgml (+52/-0)
docs/libdbusmenu-glib/reference/tmpl/client.sgml (+168/-0)
docs/libdbusmenu-glib/reference/tmpl/menuitem-proxy.sgml (+57/-0)
docs/libdbusmenu-glib/reference/tmpl/menuitem.sgml (+520/-0)
docs/libdbusmenu-glib/reference/tmpl/server.sgml (+112/-0)
docs/libdbusmenu-glib/reference/version.xml (+1/-0)
docs/libdbusmenu-glib/reference/xml/annotation-glossary.xml (+64/-0)
docs/libdbusmenu-glib/reference/xml/api-index-deprecated.xml (+8/-0)
docs/libdbusmenu-glib/reference/xml/api-index-full.xml (+105/-0)
docs/libdbusmenu-glib/reference/xml/client-menuitem.xml (+70/-0)
docs/libdbusmenu-glib/reference/xml/client.xml (+322/-0)
docs/libdbusmenu-glib/reference/xml/menuitem-proxy.xml (+103/-0)
docs/libdbusmenu-glib/reference/xml/menuitem.xml (+915/-0)
docs/libdbusmenu-glib/reference/xml/server.xml (+199/-0)
docs/libdbusmenu-gtk/Makefile.in (+613/-0)
docs/libdbusmenu-gtk/reference/Makefile.in (+685/-0)
docs/libdbusmenu-gtk/reference/html/api-index-full.html (+122/-0)
docs/libdbusmenu-gtk/reference/html/ch01.html (+42/-0)
docs/libdbusmenu-gtk/reference/html/index.html (+39/-0)
docs/libdbusmenu-gtk/reference/html/index.sgml (+33/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk-DbusmenuGtkClient.html (+316/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk-DbusmenuGtkMenu.html (+169/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk-menuitem.html (+256/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk.devhelp (+36/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk.devhelp2 (+36/-0)
docs/libdbusmenu-gtk/reference/html/object-tree.html (+42/-0)
docs/libdbusmenu-gtk/reference/html/style.css (+266/-0)
docs/libdbusmenu-gtk/reference/libdbusmenu-gtk-sections.txt (+70/-0)
docs/libdbusmenu-gtk/reference/libdbusmenu-gtk.types (+3/-0)
docs/libdbusmenu-gtk/reference/tmpl/client.sgml (+115/-0)
docs/libdbusmenu-gtk/reference/tmpl/genericmenuitem.sgml (+22/-0)
docs/libdbusmenu-gtk/reference/tmpl/libdbusmenu-gtk-unused.sgml (+118/-0)
docs/libdbusmenu-gtk/reference/tmpl/menu.sgml (+67/-0)
docs/libdbusmenu-gtk/reference/tmpl/menuitem.sgml (+84/-0)
docs/libdbusmenu-gtk/reference/version.xml (+1/-0)
docs/libdbusmenu-gtk/reference/xml/api-index-deprecated.xml (+8/-0)
docs/libdbusmenu-gtk/reference/xml/api-index-full.xml (+33/-0)
docs/libdbusmenu-gtk/reference/xml/client.xml (+214/-0)
docs/libdbusmenu-gtk/reference/xml/genericmenuitem.xml (+36/-0)
docs/libdbusmenu-gtk/reference/xml/menu.xml (+118/-0)
docs/libdbusmenu-gtk/reference/xml/menuitem.xml (+165/-0)
install-sh (+520/-0)
libdbusmenu-glib/Doxyfile (+0/-257)
libdbusmenu-glib/Makefile.in (+958/-0)
libdbusmenu-glib/client-marshal.c (+131/-0)
libdbusmenu-glib/client-marshal.h (+28/-0)
libdbusmenu-glib/dbus-menu-clean.xml.c (+132/-0)
libdbusmenu-glib/dbus-menu-clean.xml.h (+1/-0)
libdbusmenu-glib/menuitem-marshal.c (+170/-0)
libdbusmenu-glib/menuitem-marshal.h (+45/-0)
libdbusmenu-glib/server-marshal.c (+164/-0)
libdbusmenu-glib/server-marshal.h (+36/-0)
libdbusmenu-gtk/Makefile.in (+1005/-0)
ltmain.sh (+8413/-0)
missing (+376/-0)
mkinstalldirs (+162/-0)
po/Makefile.in.in (+217/-0)
tests/Makefile.in (+2204/-0)
tools/Makefile.in (+858/-0)
tools/testapp/CMakeLists.txt (+0/-29)
tools/testapp/Makefile.in (+619/-0)

lp:~ubuntu-desktop/libdbusmenu/ubuntu (Merged)

lp:ubuntu/oneiric/libdbusmenu

Revision history for this message

Ted Gould (ted) wrote on 2010-03-31:

That macro does exist in m4/introspection.m4 which we are shipping in the tarball. I'm not sure why you wouldn't be picking it up. Do you have any other compile options that might be effecting that?

Changed in dbusmenu:
status:	New → Incomplete
importance:	Undecided → Low

Revision history for this message

Dennis Schridde (devurandom) wrote on 2010-04-01:

~/libdbusmenu-0.2.8 $ patch -p0 < libdbusmenu-0.2.8-1-optional-gtk.patch 
patching file configure.ac                                                                                                                                                                                          
patching file Makefile.am                                                                                                                                                                                           
~/libdbusmenu-0.2.8 $ patch -p0 < libdbusmenu-0.2.8-2-optional-tests.patch 
patching file configure.ac                                                                                                                                                                                          
Hunk #1 succeeded at 63 (offset 7 lines).                                                                                                                                                                           
patching file Makefile.am                                                                                                                                                                                           
Hunk #1 succeeded at 7 with fuzz 2.                                                                                                                                                                                 
patching file tools/Makefile.am                                                                                                                                                                                     
~/libdbusmenu-0.2.8 $ autoreconf
libdbusmenu-glib/Makefile.am:105: HAVE_INTROSPECTION does not appear in AM_CONDITIONAL
libdbusmenu-glib/Makefile.am:132: HAVE_INTROSPECTION does not appear in AM_CONDITIONAL
libdbusmenu-glib/Makefile.am:114: addprefix $(srcdir: non-POSIX variable name
libdbusmenu-glib/Makefile.am:114: (probably a GNU make extension)
libdbusmenu-gtk/Makefile.am:51: HAVE_INTROSPECTION does not appear in AM_CONDITIONAL
libdbusmenu-gtk/Makefile.am:80: HAVE_INTROSPECTION does not appear in AM_CONDITIONAL
libdbusmenu-gtk/Makefile.am:62: addprefix $(srcdir: non-POSIX variable name
libdbusmenu-gtk/Makefile.am:62: (probably a GNU make extension)
autoreconf-2.65: automake failed with exit status: 1

Revision history for this message

Dennis Schridde (devurandom) wrote on 2010-09-20:

libdbusmenu-0.3.14-fix-aclocal.patch Edit (201 bytes, text/plain)

Attached patch fixes this issue for real. The problem was that aclocal was invoked without the -I m4 flag, which obviously made it not see the introspection macro in that directory.

Changed in dbusmenu:
status:	Incomplete → Confirmed

Ted Gould (ted) on 2011-09-03

Changed in dbusmenu:
status:	Confirmed → Fix Committed
milestone:	none → 0.4.94

Ted Gould (ted) on 2011-09-03

Changed in unity-foundations:
status:	New → Fix Committed
importance:	Undecided → Low
assignee:	nobody → Ted Gould (ted)
Changed in dbusmenu:
assignee:	nobody → Ted Gould (ted)
Changed in unity-foundations:
milestone:	none → oneiric-beta-2