dkms mkdsc template should not change access rights of upstream source

Bug #582670 reported by Steffen Barszus
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
DKMS
Confirmed
Undecided
Unassigned

Bug Description

The Makefile of the mkdsk/mkdeb template is changing the accessrights in the source to 644.

template-dkms-mkdsc/Makefile:
...
#source tree
ifeq ("$(wildcard $(NAME)-$(VERSION))", "$(NAME)-$(VERSION)")
        install -d "$(SRC)"
        cp -a $(NAME)-$(VERSION) $(SRC)
        chmod 644 -R "$(SRC)/$(NAME)-$(VERSION)"
endif

should be
#source tree
ifeq ("$(wildcard $(NAME)-$(VERSION))", "$(NAME)-$(VERSION)")
        install -d "$(SRC)"
        cp -a $(NAME)-$(VERSION) $(SRC)
endif

The Makefile should not touch accessrights, causing breakage of the build, in case executables in the source are required for the build.

Related branches

Revision history for this message
Mario Limonciello (superm1) wrote :

Fixed in 6a5b329a96635ddff4be79fafa78bd71f270919e

Changed in dkms:
status: New → Fix Committed
Changed in dkms:
status: Fix Committed → Fix Released
Revision history for this message
Steffen Barszus (steffenbpunkt) wrote :

Re-open this Bug, as the fix has been overwritten with a later commit and is those valid again.

Original patch still applies. As i dont understand the reason behind i can not suggest a solution.

Changed in dkms:
status: Fix Released → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.