(PATCH INCLUDED) Seeking bar jumps to zero when dragging or scrolling

Bug #58598 reported by Qishuai Liu
4
Affects Status Importance Assigned to Milestone
Totem
Unknown
Medium
xine-lib (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: totem

When playing rmvb files in totem-xine, if I scroll the mouse, the seeking bar jumps to zero and then jumps to the correct place. If I scroll the mouse quickly, it may jump to the start.

Steps to reproduct:
1. Install totem-xine (apt-get install totem-xine) and some codecs.
2. Open an rmvb movie.
3. Drag the seeking bar to a place.
4. Watch the seeking bar carefully when doing step 3. It firstly jump to zero and then jump to the correct place.
5. Scroll the mouse quickly. It will probably jump to start of the movie. This should not happen.

Apply this patch to solve the bug:

diff -ruNa totem-1.5.92.old/src/totem.c totem-1.5.92/src/totem.c
--- totem-1.5.92.old/src/totem.c 2006-08-15 04:41:47.000000000 +0800
+++ totem-1.5.92/src/totem.c 2006-09-02 22:57:06.941618080 +0800
@@ -953,6 +953,9 @@

        off_msec = off_sec * 1000;
        oldsec = bacon_video_widget_get_current_time (totem->bvw);
+ if (oldsec < 3) // last seeking didn't complete
+ return;
+
        sec = MAX (0, oldsec + off_msec);

        bacon_video_widget_seek_time (totem->bvw, sec, &err);
@@ -1374,7 +1377,8 @@
        update_skip_to (totem, stream_length);
        update_seekable (totem, seekable);

- if (totem->seek_lock == FALSE)
+ // if current_time == 0, 1, or 2, the last seeking may not completed
+ if (current_time > 2 && totem->seek_lock == FALSE)
        {
                gtk_adjustment_set_value (totem->seekadj,
                                current_position * 65535);

Revision history for this message
Vassilis Pandis (pandisv) wrote :

Is this your patch or did you find it somewhere? We'll probably want to forward it upstream in the first case, so they can benefit as well .

Changed in totem:
assignee: nobody → desktop-bugs
Revision history for this message
Qishuai Liu (lqs) wrote :

I did it myself.

Revision history for this message
Vassilis Pandis (pandisv) wrote :

Reported upstream. You can track the progress of the bug here: http://bugzilla.gnome.org/show_bug.cgi?id=354093 Thanks a lot for the bug and the patch!

Changed in totem:
status: Unknown → Unconfirmed
Changed in totem:
status: Unconfirmed → Rejected
Revision history for this message
Vassilis Pandis (pandisv) wrote :

From upstream: That patch is very obviously wrong. The bug is most likely in xine-lib, rather than Totem, or the xine-lib backend of Totem, and should be reported in xine's sourceforge.net tracker. See http://www.gnome.org/projects/totem/#bugs

I'm reassigning this to xine-lib...

Changed in xine-lib:
assignee: desktop-bugs → nobody
Revision history for this message
Reinhard Tartler (siretart) wrote :

I remember this bug, but cannot reproduce this with xine-lib 1.1.3. I assume it fixed then. If not, feel free to repoen and attach or link a demo file.

Changed in xine-lib:
importance: Undecided → Low
status: Unconfirmed → Fix Released
Changed in totem:
importance: Unknown → Medium
status: Invalid → Unknown
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.