Firefox 2 does not show RSS Feed preview

Bug #61182 reported by Marco Rodrigues
54
Affects Status Importance Assigned to Milestone
Mozilla Firefox
Fix Released
Medium
firefox (Ubuntu)
Fix Released
High
Alexander Sack

Bug Description

Binary package hint: firefox

Doesn't show RSS Feed preview... The answer is here:

https://bugzilla.mozilla.org/show_bug.cgi?id=353240

Thanks! Fix that please...

Revision history for this message
In , Nickolay Ponomarev (asqueella) wrote :

Created attachment 227840
patch

Revision history for this message
In , Bugs-bengoodger (bugs-bengoodger) wrote :

Comment on attachment 227840
patch

Please use Cc and Ci and the indentation style used elsewhere in this file.

If you can do that, and attach a new patch I'll check it in. This looks good. We might want to get this for b2 too if we can (since I think your approach is superior to mine).

Revision history for this message
In , Nickolay Ponomarev (asqueella) wrote :

Created attachment 230186
style nits fixed

Revision history for this message
In , Nickolay Ponomarev (asqueella) wrote :

Setting target milestone to b2 per ben's comment.

Revision history for this message
In , Nickolay Ponomarev (asqueella) wrote :

Created attachment 235507
unbitrotted

Revision history for this message
In , Nickolay Ponomarev (asqueella) wrote :

*** Bug 351726 has been marked as a duplicate of this bug. ***

Revision history for this message
In , Adam Guthrie (ispiked) wrote :

*** Bug 352648 has been marked as a duplicate of this bug. ***

Revision history for this message
Marco Rodrigues (gothicx) wrote : Mozilla Firefox Bon Echo Beta 2

Binary package hint: firefox

Doesn't show RSS Feed preview... The answer is here:

https://bugzilla.mozilla.org/show_bug.cgi?id=353240

Thanks! Fix that please...

Changed in firefox:
status: Unconfirmed → Confirmed
Revision history for this message
In , Gavin Sharp (gavin-sharp) wrote :

mozilla/browser/components/feeds/src/FeedWriter.js 1.20

Revision history for this message
Jim Braux-Zin (j-brauxzin) wrote : Re: Mozilla Firefox Bon Echo Beta 2 Doesn't show RSS Feed preview

I can confirm this problem. It's a shame that we can't enjoy this exciting new feature. I hope it will be fixed soon.

Thank you!

Revision history for this message
Slight Slightly (slight--deactivatedaccount) wrote :

Same here. Just adding a comment to mention that it's not just the preview. This also stops you from adding a feed.

Revision history for this message
Marco Rodrigues (gothicx) wrote :
Revision history for this message
Richard Bailey (rmjb) wrote :

Since, from the Mozilla bug, the xsl of a feed is part of the theme, here is a screenshot using Firefox's default theme.

Revision history for this message
Marco Rodrigues (gothicx) wrote :

I can't see any XML data there.. Try to download from Mozilla FTP and see the real diference. I like to see it in XML, before subscribe anything.

Revision history for this message
Richard Bailey (rmjb) wrote :

Well this is the view that Firefox gives of an XML feed document. So it seems the XSL is broken.

Revision history for this message
Mateusz Drożdżyński (matid) wrote :

This ought to be fixed before the release either by uploading RC2 or patching it ourselves.

Changed in firefox:
assignee: nobody → desktop-bugs
importance: Undecided → Medium
Revision history for this message
singularity (singularity00) wrote :

Any ETA on the new firefox version? It's been a quite while.

Changed in firefox:
assignee: desktop-bugs → nobody
Changed in firefox:
status: Unknown → Rejected
Revision history for this message
Martey Dodoo (martey) wrote :

This problem still occurs for me using 1.99+2.0rc2+dfsg-0ubuntu1.

Revision history for this message
Jeff Greene (jeffgreene) wrote :

I am using the RC2 that was just released and this problem still occurs. I have found a workaround which is to just change the feed settings to do a specific action instead of asking what to do every time.

Revision history for this message
Marco Rodrigues (gothicx) wrote :

Why do I think Ubuntu Firefox maintainer doesn't listen to us? It's still the same in this update for RC2..

Revision history for this message
VF (vfiend) wrote :

I can confirm that this isn't yet fixed in RC2 here, either

Revision history for this message
admarginem (admarginem) wrote :

Confirmed on: Build identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1) Gecko/0000000000 BonEcho/2.0 (Ubuntu-edgy)

Revision history for this message
Jim Braux-Zin (j-brauxzin) wrote :

I can't imagine Edgy released with this bug... Please, we are at the release candidate stage!

Revision history for this message
Alf (hubbuntu) wrote :

I'd like to confirm that not only does this break the display of feed previews, it stops the 'Subscribe Now' button working as well, so it's impossible to subscribe to any feeds.

Revision history for this message
Matt Price (matt-price) wrote : Re: [Bug 61182] Re: Mozilla Firefox Bon Echo Beta 2 Doesn't show RSS Feed preview

I agree ths is a very serious bug but fyi note there is a workaround
posted in this bug already: in preferences --> Feeds, set ANY option
other than "ask"; you will then be able to at least subscribe to feeds
again. It's not perfect, but better than the completely broken status
we have now!

matt

On Thu, 2006-19-10 at 14:02 +0000, Alf Eaton wrote:
> I'd like to confirm that not only does this break the display of feed
> previews, it stops the 'Subscribe Now' button working as well, so it's
> impossible to subscribe to any feeds.
>

Revision history for this message
magilus (magilus) wrote : Re: Mozilla Firefox Bon Echo Beta 2 Doesn't show RSS Feed preview

This is an Ubuntu only bug (as said on the Mozilla Bugzilla) and should be fixed in Edgy definitely. I'd suggest to set the milestone to ubuntu-610.

Revision history for this message
Matt Zimmerman (mdz) wrote :

Frank, is this related to the Human firefox theme?

Revision history for this message
magilus (magilus) wrote : Re: [Bug 61182] Re: Firefox 2 does not show RSS Feed preview

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I can - of course - only speak for me but I do not have
firefox-themes-ubuntu installed and the same issue appears to me.

Can anyone else verify that this also happens with the upstream Firefox
theme?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFO55b4L7OnT0GlBoRAhtgAKCDIyWchurS7raNCv+BD3N+fj5sUACfRDuG
cg24ROmp93TroQ2suHIFic8=
=yloe
-----END PGP SIGNATURE-----

Revision history for this message
Richard Bailey (rmjb) wrote :

Yes it also happens for me with the default firefox theme.

Revision history for this message
Mike Connor (mconnor) wrote : Fix from upstream

Ubuntu uses flat chrome instead of jarfiles, for some reason (its a negative hit to perf due to file I/O). This means the security check fails on the feed preview page, because the URL scheme is different.

This was fixed upstream in bug 343360, but because its really more of a developer build flag, we didn't take it on branch because it was already past RC1 freeze.

This should definitely make Edgy, the patch was retested by hacking the Edgy package (I don't have a build tree with Ubuntu's source).

Revision history for this message
Marco Rodrigues (gothicx) wrote :

Another thing.. It doesn't resume session if we close firefox with open tabs. And it works on RC3 mozilla tarball version.

Check this out please!

Revision history for this message
Mike Connor (mconnor) wrote :

I don't see that on my Edgy install. Are you talking about after a crash, or with the pref to always resume set? Both work here, but maybe that's because of this patch? If someone can get the package fixed so you could test, that'd be great.

Revision history for this message
Marco Rodrigues (gothicx) wrote :

Exactly. But at my Windows Vista RC2 with Firefox RC3, if I close it with open tabs and say "yes" to close all of them. After I open Firefox again and it ask me to resume my session. That doesn't happen in Edgy Firefox version.

Maybe something is wrong.. =)

Revision history for this message
Mike Connor (mconnor) wrote :

If you're closing the app and its prompting you to restore session, that's a bad shutdown. If you set the pref in the prefwindow, you won't get a prompt.

Try setting "When Firefox starts" to "Open my windows and tabs from last time" and test.

Revision history for this message
Marco Rodrigues (gothicx) wrote :

Where is that option ? I can't see it in Preferences, it should be at Tabs maybe.

I'm waiting for the release of Firefox with fixed RSS view.

Thanks!

Revision history for this message
Matt Zimmerman (mdz) wrote :

Unfortunately, this patch does not apply cleanly to our tree (the offsets are far different and the context is slightly different).

Also, my javascript isn't great, but isn't there a missing semicolon here?

+ newURI(SUBSCRIBE_PAGE_URI, "", null)

Revision history for this message
Mike Connor (mconnor) wrote :

Yes, that'll throw a strict warning, but still work.

I'm surprised the patch doesn't apply cleanly, but maybe it was written for trunk? Should be trivial to make the change by hand though.

Revision history for this message
magilus (magilus) wrote : Re: [Bug 61182] Re: Firefox 2 does not show RSS Feed preview

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Okay, I prepared a patch which applies against our Firefox
(1.99+2.0rc3+dfsg-0ubuntu1). Could anyone please prepare a patched .deb
so that we can try if this fixes the problem?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFPFOv4L7OnT0GlBoRAtleAJ9tbCrYz2qEt9R2E63zqG0ms/pTNgCdHyBM
slaVV+eJ7Tc/U7OFGDFLAKg=
=jQ1q
-----END PGP SIGNATURE-----

Revision history for this message
magilus (magilus) wrote :
Changed in firefox:
status: Unknown → Fix Released
Revision history for this message
Matt Zimmerman (mdz) wrote :

I've tested and uploaded this patch, but the queue is frozen for builds. If it becomes necessary to roll another with a small batch of fixes, this will be included, otherwise it will be a candidate for a post-release update.

Revision history for this message
Matt Zimmerman (mdz) wrote :

This will be in the next release build, and thusly in 6.10 final.

Changed in firefox:
status: Confirmed → Fix Released
Revision history for this message
Marco Rodrigues (gothicx) wrote :

Thanks! :-) Finally the problem was fixed. Tomorrow is Firefox v2.0 day, and thursday Ubuntu Edgy :-)

Happy release! We're all waiting for it..

Revision history for this message
magilus (magilus) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

So, the patch fixes the issue?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFPKtD4L7OnT0GlBoRAoUsAJ4uyZkxqo6K6MEkByIir8iaUrziCQCfR4rW
zNGE/eCfch8OtRGR3ufq04E=
=laMa
-----END PGP SIGNATURE-----

Revision history for this message
magilus (magilus) wrote :

Okay, didn't look at it carefully enough :-)

Revision history for this message
Matt Zimmerman (mdz) wrote :

On Mon, Oct 23, 2006 at 11:45:08AM -0000, Martin Jürgens wrote:
> So, the patch fixes the issue?

Yes, it did for me.

--
 - mdz

Revision history for this message
Martey Dodoo (martey) wrote :

Issue has recurred in Feisty with 2.0.0.1+1-0ubuntu1. Changelog includes this entry:

"drop FeedWriter.js patch, no rational available."

Changed in firefox:
status: Fix Released → Confirmed
Revision history for this message
Alexander Sack (asac) wrote :

This is a regression. I saw no changelog entry about this bug report. Now we learned the rational of this patch the hard way. Will reapply asap.

Changed in firefox:
assignee: nobody → asac
status: Confirmed → In Progress
Revision history for this message
Alexander Sack (asac) wrote :

importance high, as this is a regression in latest feisty upload.

Changed in firefox:
importance: Medium → High
Revision history for this message
Alexander Sack (asac) wrote :

fix in feisty: 2.0.0.2+1-0ubuntu1

Changed in firefox:
status: In Progress → Fix Released
Changed in firefox:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.