bugfixes and feature improvements

Hi Péter, you can attach debdiff containing patches and necessary description about changes on this bug report and assign it to motureviewers
https://wiki.ubuntu.com/MOTU/Teams/Reviewers

debdiff attached. It was generated this way:

  $ wget http://archive.ubuntu.com/ubuntu/pool/universe/j/joe/joe_3.1-0.2_i386.deb
  $ wget
http://www.szszi.hu/~pts/joe/joe_3.5-3_i386.deb
  $ debdiff joe_3.1-0.2_i386.deb joe_3.5-3_i386.deb >joe-3.1-3.5-ubuntu-dapper.debdiff

Download our patches from http://www.szszi.hu/wiki/JoePatches

List of our modification follows.

The 1st patch fixes a few bugs and quirks, and also adds a few small features. If necessary, we can split this patch to several smaller patches.

Bugfixes:

    * pfcol() is updated so it now doesn't move the cursor to the nearest character boundary while computing p->col.
          o The fix fixes the issue when the column field (%c) in status line gets updated (pfcol() called from stagen() called from disptw() called from edupd() called from ttgetc() called from edloop() called from main()), and the cursor is not standing on a proper UTF-8 charcacter boundary (possibly in hex mode).
          o The original implementation had a side effect: it changed b->byte etc., moving the cursor forward to the next boundary (which was a side effect of `while (p->byte < pos) pgetc(p);'). This was certainly incorrect, because it caused the cursor to move actually rightwards with `ltarw' command (which is supposed to move it leftwards), when that command was executed along with a status line refresh.
          o The fix here changes only p->col and p->valcol, other attributes (especially p->byte) are left unaffected. The behaviour of the fix is identical to the original when p is standing on UTF-8 character boundary. On the other hand, if p is in the middle of an UTF-8 character, p->col is set to the column at the beginning of that character.
    * Fixed a segfault in docmd() and exmacro() when an empty (whitespace) macro is specified.
    * Fixed a typo (> 255) in macro.c.
    * Fixes in utypeb_raw() for proper insertion of bytes in hex and nonhex mode.
    * time_rc was not initialized in main(). Bug found using valgrind(1).
    * Fixes in main() to support .joerc file and folder names containing spaces.
    * Small fixes to procrc() for handling long configuration lines.

New or improved features:

    * ustat() (the stat command) now displays the number of bytes the current UTF-8 character occupies.
    * If the environment variable NO_JOERC is present, system configuration files (such es /etc/joe/joerc) are not parsed. (Many functions affected.) The reason for this improvement is that on some systems JOE configuration files are completely bogus, so the user should be able to tell JOE to ignore those files and read configuration from the user's home directory instead.
    * Ditto for the JOE syntax highlighting configuration files.
    * The configuration file line maximum line length is increased from 1024 to 4096 in procrc().
    * If a configuration file line is too long, an error message is displayed, the line is processed truncated, and line numbering continues working. Modified procrc().
    * New built-on commands fwrdhist (ufwrdhist()) and bkwdhist (ubkwdhist()) are provided. These commands are useful in history buffers. They jump to the next or previous line, respectively, which...

debdiff generated this way:

  $ wget http://librarian.launchpad.net/3063801/joe_3.3-5_i386.deb
  $ wget
http://www.szszi.hu/~pts/joe/joe_3.5-3_i386.deb
  $ debdiff joe_3.3-5_i386.deb joe_3.5-3_i386.deb >joe-3.3-3.5-ubuntu-edgy.debdiff

> and assign it to motureviewers

I don't quite understand this. I use the URL https://launchpad.net/distros/ubuntu/+source/joe/+bug/63952
, but there seems to be no link to assign the bug to somebody.

Could you generate diffs from source packages instead of binaries?
Thanks.

I've created the source debdiff this way:

$ wget http://librarian.launchpad.net/3037941/joe_3.3-5.dsc
$ wget http://librarian.launchpad.net/3037940/joe_3.3-5.diff.gz
$ wget http://librarian.launchpad.net/3037939/joe_3.3.orig.tar.gz
$ wget http://www.szszi.hu/~pts/joe/joe_3.5-3.dsc
$ wget http://www.szszi.hu/~pts/joe/joe_3.5-3.tar.gz
$ wget http://www.szszi.hu/~pts/joe/joe_3.5-3_i386.deb
$ debdiff joe_3.3-5.dsc joe_3.5-3.dsc > pts-joe-3.1-3-5-unbuntu-dapper-src.debdiff

The debdiff is quite big (2.2 MB). That's because there are a lot of differences between joe-3.3 and joe-3.5. Please read our small diffs instead. They are directly downloadable from http://www.szszi.hu/wiki/JoePatches . Their total size is 54 kB (but most of the diff consists of the repetion of the original context).

If you are really interested in the 2.2 MB .debdiff, here it is: http://www.szszi.hu/~pts/joe/pts-joe-3.1-3-5-unbuntu-dapper-src.debdiff

This will probably be considered for Edgy +1. In the meantime, have you tried getting your patches merged for Debian version which Ubuntu will eventually sync?

You can make the review process easier by splitting one big patch which adds features/fixes bugs to separate individual patches.

I have sent the patch to Debian and JOE. The Debian people are waiting for the JOE authors to accept the patch first.

I am a little confused here, why are you using the 3.3 packages to diff against when both Debian and Ubuntu have 3.5-1.1? Could you create a diff of your changes against those packages? Thank you!

Gah, sorry, in Edgy it was still 3.3-5. That being said, could you please re-post your patch against the 3.5-1.1 version in Feisty? Thanks again.

> Gah, sorry, in Edgy it was still 3.3-5. That being said, could you
> please re-post your patch against the 3.5-1.1 version in Feisty?
> Thanks
> again.

I don't quite understand the problem here. You have all the information
you need: you have 3.3-5 and my patch and 3.5-1.1, so you can generate
whatever patch you need using patch(1) and diff(1).

You can also download all patches and .tar.gz s from here:

http://www.szszi.hu/~pts/joe/

The problem is that your debdiff is huge and includes way more changes than what are easily reviewable . Please debdiff from the current Feisty version so we can see *just* what you want to change.

I've unsubscribed ubuntu-universe sponsors, as the patches are not in debdiff format, and so this is not a sponsorship request. I have added the patch tag to indicate that patches are available, and should be included in a new candidate revision. If a debdiff is prepared against the current development environment, please resubscribe ubuntu-universe-sponsors to request an upload. Thank you.

[Expired for joe (Ubuntu) because there has been no activity for 60 days.]