viewing attachments fails when filenames have spaces

Binary package hint: flim

I encountered a problem opening (playing) attachments in an external program, when the designated file name contained spaces. I traced this to an issue of double-quoting. In my /etc/mailcap on Ubuntu 10.04, it says something like

    application/pdf; evince '%s'

Because of those single quotes, it is incorrect to quote the spaces in the filename. However, mime-format-mailcap-command calls shell-quote-argument anyway, so it ends up trying to run

    evince '/tmp/blahblah/My\ Silly\ Proposal.pdf'

And so evince opens up but says "File cannot be opened" because it's looking for a file with literal backslashes in the name.

Probably, removing shell-quote-argument is not the best behavior, because it is dependent on how the commands in mailcap are written. So instead, I have this small patch that looks for quotes in the mailcap command, and if %s is inside quotes, then it does not invoke shell-quote-argument before substituting. This workaround seems to work for me, though I'd appreciate confirmation of the bug and the fix from others.

Best wishes,
Chris

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: flim 1:1.14.9-4.1
ProcVersionSignature: Ubuntu 2.6.32-25.45-generic 2.6.32.21+drm33.7
Uname: Linux 2.6.32-25-generic i686
Architecture: i386
Date: Wed Nov 17 15:46:23 2010
Dependencies: apel 10.7-3
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release i386 (20100429)
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.utf8
 SHELL=/bin/zsh
SourcePackage: flim