[PATCH] Can't see window requesting attention from a different workspace

Bug #798197 reported by Andy Balaam
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
window-picker-applet (Ubuntu)
New
Undecided
Unassigned

Bug Description

Binary package hint: window-picker-applet

When a window requests attention, its icon flashes in window-picker-applet.

However, when I uncheck the setting "Show windows from all workspaces" and a window on a different workspace requests attention, I don't see it until I switch to the workspace containing the window.

The patch below modifies the behaviour so that windows requesting attention are visible on all workspaces.

This happens on window-picker-applet-0.5.10 on Ubuntu 10.04.2 LTS, but the patch is against the latest upstream git, which I believe is called 0.5.8-1?

Note other words for workspace may include viewport or virtual desktop.

diff --git a/src/task-item.c b/src/task-item.c
index 55f3e27..c99c6b4 100644
--- a/src/task-item.c
+++ b/src/task-item.c
@@ -170,7 +170,11 @@ task_item_set_visibility (TaskItem *item)

   if (!wnck_window_is_skip_tasklist (window))
   {
- if (wnck_workspace_is_virtual (workspace))
+ if (wnck_window_or_transient_needs_attention (window))
+ {
+ show_window = TRUE;
+ }
+ else if (wnck_workspace_is_virtual (workspace))
     {
       show_window = wnck_window_is_in_viewport (window, workspace);
     }

Tags: patch
Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :
Revision history for this message
andreselsuave (andreselsuave) wrote :

How can I apply the patch? or will I have to wait for the next unity version?

Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :

Hi andreselsuave, here is a brief outline of how I built the applet with this patch applied:

sudo apt-get install build-essential fakeroot dpkg-dev
sudo apt-get build-dep window-picker-applet
mkdir tmp
cd tmp
apt-get source window-picker-applet
cd window-picker-applet-*
wget https://bugs.launchpad.net/ubuntu/+source/window-picker-applet/+bug/798197/+attachment/2171550/+files/show-windows-requring-attention-on-all-workspaces.patch
patch -p1 < show-windows-requring-attention-on-all-workspaces.patch
dpkg-buildpackage -rfakeroot -b
cd ..
sudo dpkg -i window-picker-applet_*.deb
killall gnome-panel

tags: added: patch
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.