Please sync zsnes 1.510+bz2-1 (universe) from Debian unstable (main)

Thank you for requesting this sync. We generally sync from unstable unless there's a specific reason not to. In this case, the same version is in unstable and testing. I'm testing this build now.

So, this fails to build on i386 now on oneiric in addition to failing on amd64 due to a missing ia32-libs-dev. Relevant log excerpt:
g++ -o zsnes cfg.o endmem.o init.o initc.o input.o md.o patch.o ui.o vcache.o version.o zloader.o zmovie.o zpath.o zstate.o ztime.o ztimec.o chips/c4emu.o chips/c4proc.o chips/dsp1emu.o chips/dsp1proc.o chips/dsp2proc.o chips/dsp3emu.o c
hips/dsp3proc.o chips/dsp4emu.o chips/dsp4proc.o chips/fxemu2.o chips/fxemu2b.o chips/fxemu2c.o chips/fxtable.o chips/obc1emu.o chips/obc1proc.o chips/sa1proc.o chips/sa1regs.o chips/sdd1emu.o chips/seta10.o chips/sfxproc.o chips/st10pro
c.o chips/7110proc.o chips/seta11.o chips/st11proc.o cpu/dma.o cpu/dsp.o cpu/dspproc.o cpu/execute.o cpu/executec.o cpu/irq.o cpu/memory.o cpu/memtable.o cpu/spc700.o
 cpu/stable.o cpu/table.o cpu/tablec.o gui/gui.o gui/guifuncs.o gui/menu.o effects/burn.o effects/smoke.o effects/water.o jma/7zlzma.o jma/crc32.o jma/iiostrm.o jma/inbyte.o jma/jma.o jma/lzma.o jma/lzmadec.o jma/winout.o jma/zsnesjma.o mmlib/mm.o mmlib/linux.o video/makev16b.o video/makev16t.o video/makevid.o video/mode716.o video/mode716b.o video/mode716d.o video/mode716e.o video/mode716t.o video/mode7.o video/mode7ext.o video/mv16tms.o video/m716text.o video/newg162.o video/newgfx.o video/newgfx16.o video/newgfx2.o video/procvid.o video/procvidc.o video/sw_draw.o video/2xsaiw.o video/hq2x16.o video/hq2x32.o video/hq3x16.o video/hq3x32.o video/hq4x16.o video/hq4x32.o video/ntsc.o video/copyvwin.o linux/audio.o linux/battery.o linux/sdlintrf.o linux/sdllink.o linux/gl_draw.o linux/sw_draw.o linux/safelib.o zip/unzip.o zip/zpng.o -m32 -pipe -I. -I/usr/local/include -I/usr/include -D__UNIXSDL__ -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -DNO_DEBUGGER -D__LIBAO__ -D__OPENGL__ -march=i486 -O3 -fomit-frame-pointer -fprefetch-loop-arrays -fforce-addr -s -D__RELEASE__ -lpthread -L/usr/local/lib -L/usr/lib -lz -L/usr/lib -lSDL -lpng -lm -lao -lGL
g++: error: cfg.o: No such file or directory
g++: error: input.o: No such file or directory
g++: error: md.o: No such file or directory
make[1]: *** [main] Error 1
make[1]: Leaving directory `/build/micah-zsnes_1.510+bz2-1-i386-0KjKr3/zsnes-1.510+bz2/src'
dh_auto_build: make -j1 returned exit code 2
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

Please resubscribe ubuntu-sponsors when this is ready for sponsorship again. Also, please note that the requestsync tool in ubuntu-dev-tools can create sync requests for you.

BTW, we're only building i386 on this package right now, so if that gets fixed, we can sync the package.

Hello, debian maintainer here.

The i386 build works fine on unstable. If you can send me a full i386 build log, I will see what I can do. As for the amd64 build, I believe that it will be easier when multiarch will be available in Debian.

Sorry, I usually attach the full build log, here it is.

ia32-libs-dev missing in Ubuntu. You should replace ia32-libs-dev on ia32-libs and add lib32stdc++6 in build-depends.

I think you should look at this ppa: https://launchpad.net/~smaxein/+archive/ppa

znses build on ubuntu natty. (amd64 and i386).

http://ftp.de.debian.org/debian/pool/main/z/zsnes/zsnes_1.510+bz2-1.debian.tar.gz

control file in Debian:

Build-Depends:
 debhelper (>= 8),
 nasm,
 libsdl1.2-dev (>= 1.2.2-3.1),
 sharutils,
 libpng12-dev | libpng-dev,
 autotools-dev,
 zlib1g-dev [i386] | lib32z1-dev [amd64],
 libao-dev [i386],
 dpkg-dev (>= 1.13.2),
 gcc-multilib [amd64],
 g++-multilib [amd64],
 ia32-libs-dev [amd64]
Standards-Version: 3.9.1
Vcs-Git: git://git.debian.org/pkg-games/zsnes.git
Vcs-Browser: http://git.debian.org/?p=pkg-games/zsnes.git

Package: zsnes
Architecture: i386 amd64
Depends: ${shlibs:Depends}, ${misc:Depends}

In ppa control file:

https://launchpad.net/~smaxein/+archive/ppa/+files/zsnes_1.510%2Bbz2-2%7Eppa6.debian.tar.gz

Build-Depends:
 debhelper (>= 8),
 nasm,
 libsdl1.2-dev (>= 1.2.2-3.1),
 sharutils,
 libpng12-dev | libpng-dev,
 autotools-dev,
 zlib1g-dev [i386] | lib32z1-dev [amd64],
 libao-dev [i386],
 dpkg-dev (>= 1.13.2),
 gcc-multilib [amd64],
 g++-multilib [amd64],
 ia32-libs [amd64],
 lib32stdc++6 [amd64],
 quilt
Standards-Version: 3.9.1
Vcs-Git: git://git.debian.org/pkg-games/zsnes.git
Vcs-Browser: http://git.debian.org/?p=pkg-games/zsnes.git

Package: zsnes
Architecture: i386 amd64
Depends: ${shlibs:Depends}, ${misc:Depends}

Also exist patch:

0009-hat-events.patch:

Index: zsnes-git/src/linux/sdllink.c
===================================================================
--- zsnes-git.orig/src/linux/sdllink.c 2011-01-27 16:39:27.543274001 +0100
+++ zsnes-git/src/linux/sdllink.c 2011-01-28 12:50:05.743614935 +0100
@@ -307,6 +307,8 @@
           case SDL_HAT_UP:
             pressed[offset + 3] = 1;
             pressed[offset + 2] = 0;
+ pressed[offset + 1] = 0;
+ pressed[offset + 0] = 0;
             break;
           case SDL_HAT_RIGHTUP:
             pressed[offset] = 1;
@@ -317,6 +319,8 @@
           case SDL_HAT_RIGHT:
             pressed[offset] = 1;
             pressed[offset + 1] = 0;
+ pressed[offset + 2] = 0;
+ pressed[offset + 3] = 0;
             break;
           case SDL_HAT_RIGHTDOWN:
             pressed[offset] = 1;
@@ -326,6 +330,8 @@
             break;
           case SDL_HAT_DOWN:
             pressed[offset + 2] = 1;
+ pressed[offset + 0] = 0;
+ pressed[offset + 1] = 0;
             pressed[offset + 3] = 0;
             break;
           case SDL_HAT_LEFTDOWN:
@@ -337,6 +343,8 @@
           case SDL_HAT_LEFT:
             pressed[offset + 1] = 1;
             pressed[offset] = 0;
+ pressed[offset + 2] = 0;
+ pressed[offset + 3] = 0;
             break;
           case SDL_HAT_LEFTUP:
             pressed[offset + 1] = 1;

_FORTIFY_SOURCE used in ubuntu (but not in debian) somehow breaks parsegen. natty is also not affected.
the simple fix would be to just disable the fortification for the 3 files it compiles.

cfg.c:600:7: sorry, unimplemented: called from here
/usr/include/bits/stdio2.h:96:1: sorry, unimplemented: inlining failed in call to 'fprintf': indirect function call with a yet undetermined callee

--- zsnes-1.510+bz2.orig/src/Makefile.in 2011-08-06 00:11:41.000000000 +0200
+++ zsnes-1.510+bz2/src/Makefile.in 2011-08-06 00:15:24.299201891 +0200
@@ -95,7 +95,7 @@
 %.o: %.cpp
  @CXX@ @CXXFLAGS@ -o $@ -c $<
 %.o %.h: %.psr $(PSR)
- ./$(PSR) @PSRFLAGS@ -gcc @CC@ -compile -flags "@CFLAGS@ -O1" -cheader $*.h -fname $* $*.o $<
+ ./$(PSR) @PSRFLAGS@ -gcc @CC@ -compile -flags "@CFLAGS@ -O1 -D_FORTIFY_SOURCE=0" -cheader $*.h -fname $* $*.o $<

 default: main
 all: main tools

is the issue in bug 250425 (also _FORTIFY_SOURCE related) been fixed in the new version?
if not we need to merge, not sync.

In Ubuntu 12.04 zsnes:i386 installable in x64 system. Update isn't required.