Initscripts in main need init-function love

*** Bug 8271 has been marked as a duplicate of this bug. ***

Created an attachment (id=446)
backuppc package diff

Created an attachment (id=447)
bind9 package diff

Created an attachment (id=448)
bluez-utils package diff

Created an attachment (id=449)
courier package diff

Created an attachment (id=450)
cyrus package diff

Created an attachment (id=451)
dhcp3 package diff

Created an attachment (id=809)
LSB version of laptop-mode

Created an attachment (id=810)
alsa init script

*** Bug 10691 has been marked as a duplicate of this bug. ***

(In reply to comment #2)
> Created an attachment (id=446) [edit]
> backuppc package diff
>

 backuppc (2.1.0-7ubuntu1) hoary; urgency=low
 .
   * Nathaniel McCallum:
     - debian/backuppc.init: pretty initscript
     - debian/control: versioned depend on lsb-base
 .
   * Remove dependency on wwwconfig-common

(In reply to comment #3)
> Created an attachment (id=447) [edit]
> bind9 package diff
>

 bind9 (1:9.2.4-1ubuntu1) hoary; urgency=low
 .
   * Nathaniel McCallum
     - debian/init.d: pretty initscript
     - debian/control: versioned depend on lsb-base

(In reply to comment #4)
> Created an attachment (id=448) [edit]
> bluez-utils package diff
>

 bluez-utils (2.10-4ubuntu1) hoary; urgency=low
 .
   * Nathaniel McCallum
     - debian/init.d: pretty initscript
     - debian/control: versioned depend on lsb-base

(In reply to comment #5)
> Created an attachment (id=449) [edit]
> courier package diff
>

 courier (0.47-3ubuntu1) hoary; urgency=low
 .
   * Nathaniel McCallum
    - debian/*.init: pretty initscripts
    - debian/control: version depends on lsb-base

Created an attachment (id=835)
LSB init script for makedev

Created an attachment (id=836)
LSB init script for sudo

Created an attachment (id=837)
LSB init script for smartmontools

netbase also needs changes (I see an "rp_filter" message interspersed with
normal output during boot)

Created an attachment (id=839)
LSB init script for netbase

I've added the LSB functions, however, it just prints "rp_filter", perhaps we
should replace this by something more meaningfull? (What's rp_filter anyway?)

Created an attachment (id=840)
LSB init script for quota

Created an attachment (id=841)
LSB init script for vsftpd

Created an attachment (id=849)
LSB init script for alsa

Updated alsa patch, applies cleanly again

Created an attachment (id=1700)
init-function patch for /etc/init.d/xinetd

*ping*

Are all these patches already applied, so we can close this bug?

Have the patches been applied?

May this bug be Closed?

Thank you.

Most of these I know to have been fixed, a few may have been removed from main, and a few most likely remain to be done. I think all of the attached patches have been applied or obsoleted, though the patches do not cover all of the packages in the list.

A good quick check is to see if the package depends on lsb-base, so if someone could process this list and see what remains to be done, that would be helpful.

I did a quick check of these packages, with the following results:

Doesn't use lsb-base functions:
cyrus21-base
dovecot-common
exim4-base
festival
heartbeat
mailman
mgetty-fax
mysql-server
nessusd
nis
pptpd
quagga
quota
radvd
setserial
shorewall
slapd
snmpd
xinetd

No depends on lsb-base, though functions are used in the init script:
backuppc
smartmontools

Insufficient dependencies:
dhcp3-server depends on lsb-base, should be >> 3.0-1ubuntu4

Other issues:
bluez-utils writes "hcid sdpd" on a second line.

There are a few packages which just depend on lsb-base, no particular version specified. I don't know if it's worth going through this list though (I pointed out the dependency above because of the particular usplash function call).

Uses log_action_begin_msg, log_action_cont_msg, log_action_end_msg, log_warning_msg to replace previous echo statements.
Also hides stdout from setserial.

Use log_daemon_msg, log_end_msg, log_warning_msg instead of echo in init script.

Use log_daemon_msg, log_progress_msg, log_end_msg instead of echo statements in init script.

bluez-utils printed out the daemon names to stdout.
This patch uses log_daemon_msg and log_progress_msg instead of log_begin_msg and echo.
lsb-base dependency is also updated.

Added log_daemon_msg/log_warning_msg/log_end_msg/log_action_begin_msg/log_action_end_msg in init scripts, to replace echo commands.

FYI, I opened separate bugs for a few of these issues (since I had patches) so they could be tracked separately:
bug 43551
bug 43569
bug 43573
bug 43574
bug 43575

None of these init scripts are actually provided by sysvinit/initscripts - so not sure how the bug ended up here.

Please open individual bugs for any remaining problems.