race condition in USR1 signal handling in mountall

Bug #960079 reported by Eelco Dolstra
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
mountall (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

There is a slight race condition in the way mountall installs its USR1 signal handler. It does that after daemonising, so as a result the mountall-net job might send it the USR1 signal after the mountall job has reached the start/running state but before it has installed the signal handler. This will result in mountall getting killed.

Example of an automated test run showing this problem: http://hydra.nixos.org/build/2309161/log/raw. The relevant line is:

client2# [ 10.963784] init: mountall main process (1971) killed by USR1 signal

The attached patch (to mountall 2.35) fixes this by moving the installation of the USR1 handler to before the fork.

Tags: patch

Related branches

Revision history for this message
Eelco Dolstra (e-dolstra) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "install the USR1 signal handler before daemonising" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Steve Langasek (vorlon)
Changed in mountall (Ubuntu):
importance: Undecided → Medium
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mountall - 2.38

---------------
mountall (2.38) unstable; urgency=low

  * Counterproductively document in debian/copyright the license of files in
    intl that form no part of the binary package, to get through the Debian
    NEW queue.

 -- Steve Langasek <email address hidden> Sat, 30 Jun 2012 11:44:59 -0700

Changed in mountall (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.