Wrong SN in feedback
Bug #970762 reported by
Didier Barvaux
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| rohc | Status tracked in Rohc-main | |||||
| 1.2.x |
Won't Fix
|
Medium
|
Didier Barvaux | |||
| 1.3.x |
Won't Fix
|
Medium
|
Didier Barvaux | |||
| Rohc-main |
Fix Released
|
High
|
Didier Barvaux | |||
Bug Description
Arne reported several problems in bug #953947. Some of them are enhancement with low priority, but the last one about SN in feedback is of high importance. That bug causes a wrong SN to be written in the feedback data. Below is the copy/paste of the relevant part of Arne's bug report. Thanks to him for detecting that problem!
decomp/feedback.c
-------
At least a short fix for a wrong calculated SN inside the feedback.
85:
feedback->data[1] = sn & 0xff00 >> 8;
change to
feedback->data[1] = (sn & 0xff00) >> 8;
Revision history for this message
| Didier Barvaux (didier-barvaux) wrote | #1 |
Revision history for this message
| Didier Barvaux (didier-barvaux) wrote | #2 |
Revision history for this message
| Didier Barvaux (didier-barvaux) wrote | #3 |
Revision history for this message
| Didier Barvaux (didier-barvaux) wrote | #4 |
To post a comment you must log in.
Nother problem with SN in FEEDBACK-2: it is not always transmitted in NBO :(