Landscape Server

  1. Bug #279343
  2. Comment #1

Comment 1 for bug 279343

Revision history for this message
Thomas Herve (therve) wrote :

Let's go!

[1]
- self.addSuccessor(config, (upgpkg, REMOVE), OPTIONAL)
+ self.addSuccessor(unpack, (upgpkg, REMOVE), OPTIONAL)

This change looks untested :/. I don't know how hard it would be to trigger it. But it looks like the tests don't even go through this path at all

[2] test.py is referenced in several places in the code: MANIFEST.in, usage of the file itself, and in the locale files.

[3] Some flakes
mart/fetcher.py:32: 'string' imported but unused
smart/fetcher.py:1716: 'ftplib' imported but unused
tests/debpm.py:2: 'copy' imported but unused
tests/debpm.py:12: 'REMOVE' imported but unused

[4] Maybe bug #273605 could be solved here?

Thanks!