Comment 7 for bug 1346935

Revision history for this message
Scott Moser (smoser) wrote :

Felipe,
  A couple comments on your debdiffs.
a.) Please add dep8 comments, and point to the upstream commits if you can.
b.) in trunk, we dropped use of 'strip_version' everywhere in revno 362 [1] , then a pep8 cleanup in revno 364 [2], but then added the strip_version *back* for glance at revno 365 [3]. revno 365 was 2014-12-12, only 2 days after 362. I have since lost context, but I suspect that doing so broke an older cloud (quite possibly canonistack).

It seems that you have incorporated upstream commits 362 and 364 but not 365.

As I said in commit message at 365, strip_version is certainly nefarious, but seems to be necessary.

--
[1] http://bazaar.launchpad.net/~smoser/simplestreams/trunk/revision/362
[2] http://bazaar.launchpad.net/~smoser/simplestreams/trunk/revision/364
[3] http://bazaar.launchpad.net/~smoser/simplestreams/trunk/revision/365