Comment 42 for bug 1448092
Revision history for this message
| Mathieu Trudel-Lapierre (cyphermox) wrote | #42 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
The package has vastly improved, but I could still find some issues.
changelog, control, compat, etc. Basically, anything other than rules and maintainer scripts don't need to be executable files. I'm not blocking the upload on that though.
manpages appear to be compressed including timestamps, this should be avoided if possible; through the use of the -n parameter to gzip. This allows us to make reproducible builds. Again, not blocking on that.
I'm merely blocking on getting a clear idea of why there are extra messages about crontab when installing:
Unpacking dialog (1.2-20140911-1) ...
Processing triggers for man-db (2.7.0.2-5) ...
Setting up dialog (1.2-20140911-1) ...
Setting up ibmpmlinux (3.2.0-0ubuntu1) ...
International Business Machines(IBM) Corporation, Rochester, MN, USA
Performance Management for LINUX - PMLinux Copyright 2012-2015 (C)
verifying PMLinux at /opt/ibm/pm flexibly !!!
/var/opt/
PMLinux transmission link is there, pass
Link /usr/sbin/
Register PMLinux invocation in /etc/cron ... done(0)
no crontab for root
*** WARNING *** PMLinux contact email() is NOT entered yet!!!
PMLinux 3.2.0-1 verification completed.
There also shouldn't be the creation of a link to *anything* outside of /opt in postinst scripts, certainly not /usr/sbin/
What worries me here is, what would be the behavior if someone already has entries in root's crontab? Will an entry be created there then? There should never be a change to root's crontab from package maintainer scripts.
Finally, you shouldn't need most of the maintainer scripts. preinst and postrm appear to duplicate work that should already be done by the package manager, which should already correctly handle upgrades where the contents of a binary might have changed. These maintainer scripts should probably be removed, they seem to only be there due to the conversion process used to get the first deb package from the original RPM.