On Thu, Apr 23, 2009 at 08:43:07AM -0000, Matt Zimmerman wrote:
> In cases like these, it's a good idea to attach the information *only* if
> it's interesting, since we can determine that from the system. If
> /proc/pid/attr/current says only "unconfined", this doesn't carry any new
> information, and we should just omit it.
Except where something was expected to have an apparmor policy applied
to it but does not -- it can be detected by the absence of the entry but
detection by omission is generally a hard thing for people to do. That
said, I'll concede the point.
> Similarly, we can only attach configuration files which differ from the
> default. There's a hookutils function for this already, which I hope to see
> enabled by default for Ubuntu.
I recall using it to pull out the gconf settings for the
gnome-power-manager apport hook I wrote. Two issues that I see:
1) In the devel cycle, defaults can change. Given our overwhelming
number of bugs, the current defaults that a triager sees for a
package may differ from the defaults as they were when the bug
was reported.
2) Our defaults may differ from an upstream's defaults and that may
not be obvious to an upstream developer looking at our bug reports.
But I'll stop bike-shedding and shut up now (or at least can continue
the discussion elsewhere, if desired).
On Thu, Apr 23, 2009 at 08:43:07AM -0000, Matt Zimmerman wrote: attr/current says only "unconfined", this doesn't carry any new
> In cases like these, it's a good idea to attach the information *only* if
> it's interesting, since we can determine that from the system. If
> /proc/pid/
> information, and we should just omit it.
Except where something was expected to have an apparmor policy applied
to it but does not -- it can be detected by the absence of the entry but
detection by omission is generally a hard thing for people to do. That
said, I'll concede the point.
> Similarly, we can only attach configuration files which differ from the
> default. There's a hookutils function for this already, which I hope to see
> enabled by default for Ubuntu.
I recall using it to pull out the gconf settings for the
gnome-power-manager apport hook I wrote. Two issues that I see:
1) In the devel cycle, defaults can change. Given our overwhelming
number of bugs, the current defaults that a triager sees for a
package may differ from the defaults as they were when the bug
was reported.
2) Our defaults may differ from an upstream's defaults and that may
not be obvious to an upstream developer looking at our bug reports.
But I'll stop bike-shedding and shut up now (or at least can continue
the discussion elsewhere, if desired).
-- NxNW.org/ ~steve/
Steve Beattie
<email address hidden>
http://