Comment 9 for bug 1309447

Revision history for this message
Mekk (marcin-kasperski) wrote :

From the comment which I see in this patch ("open in unicode mode..."), it looks like somebody intended to go towards handling file content as unicode. Your patch reverts it towards binary. Maybe it would be better to attempt input decoding (guessing the encoding somehow, at least considering utf-8 and locale-preferred encoding)? I don't remember what/how this exactly works in python3, so feel free to ignore this remark.

(sidenote: I am fairly curious what would happen if I saved some config files as utf-16 ;-))