Comment 22 for bug 622313

Revision history for this message
Chow Loong Jin (hyperair) wrote : Re: [Bug 622313] Re: 'Music library not found' message returned when no search results are returned

On Friday 15,April,2011 06:01 PM, Bertrand Lorentz wrote:
> This patch improves on the one currently applied in the Ubuntu package by disconnecting the event handler once
> there are tracks in the library. This means that the message will not be shown if searches return no tracks.
>
> It also makes the message translatable, which is this other bug :
> https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/619303

Woo, thanks! But this depends on the LibraryWatcher to be relevant at all, which
has a bunch of issues (see Bug #760902).

Perhaps we should shift the patch to the LibraryWatcher extension instead, so
that the message only appears when the LibraryWatcher extension is enabled? This
would also allow it to go upstream, won't it?

>
> And yes, I'm an upstream dev improving a distro patch... ;)

Commit it already, won't you? ;-)

--
Kind regards,
Loong Jin