Comment 2 for bug 371829

Revision history for this message
Mathias Gug (mathiaz) wrote :

Thanks for taking the time to prepare a merge. Here are a few comments:

- could you remove all the changelog entries related to unstable that appear in the diff ( <0.6.12-5)? Only entries relevant to the ubuntu packages should be appear in the debdiff.

- It seems that the patch system used in the package is dpatch (as mentioned in the debian entry 2:8.3.0-2). Even though there isn't any patch applied now, it's better to use the Debian patch management system. drbd/linux/drbd.h is patch inlined - dpatch should be used instead.

Related to the last point, is the patch still needed for karmic considering that the kernel is going to be updated soon? Are there any changes needed with regard to the new version of drbd in the kernel?