Comment 8 for bug 272593

On Tue, 2008-09-30 at 16:18 +0000, Tom Jaeger wrote:
> James Westby wrote:
> > I got four warnings originally, so could you double check that you didn't miss one?
> > It looks like you may create a GtkSpinButton in the code, as well as in the glade.
> >
> Yup, I got rid of all the warnings.

Great, thanks.

> > Also, I don't think it's important to fix this in Intrepid, as it is
> > only a warning.
> >
> These warnings are all over the place now. This change should have
> really been made at the beginning of the release cycle, as the warnings
> are only helpful to developers, not to users. Hopefully, they'll revert
> it before the intrepid release.

Actually the new gtk broke compatibility without the warning, after we
discovered this we pushed to get the warning instead, so that at least
we will have working applications.

I agree they are not helpful to users though.

> > As for the Documentation thing your code doesn't seem to call set_uri_hook
> > anywhere, so I presume that gtk has no idea what to do with the link. I would
> > suggest you use xdg-open to open the link.
> >
> Thanks, fixed in git. Do you think this is worth backporting to intrepid?

I would upload a package with these two fixes applied.

Thanks,

James