Comment 6 for bug 68852

Revision history for this message
Siegfried Gevatter (rainct) wrote :

Hey,

Looks quite good, just a little suggestion about the changelog entry: replace "* find/find.1:" with "* patches/01_nullescape.dpatch, patches/00list:", as those are the files that you modified directly (and reference find/find.1 in the line below this one); otherwise reading just the changelog entry it seems like you modified the file directly, without using a patch, and if someone wants to know when the 01_nullescape patch was added he would have to read through all the changes to find it.

Also, consider adding the fix for bug #202431 to your patch so that both are solved with the same upload.

Ah, and don't worry that nobody said anything about your debdiff before, main is slow... ;).