Comment 82 for bug 68040

Revision history for this message
In , Bzbarsky (bzbarsky) wrote :

Fix the indent of the nsIVariant in the IDL?

The "No args" comment on the OpenInternal call should probably be adjusted.

Most important from my point of view: this functionality won't work in any embedded build (because it relies on nsXULWindow). Couldn't that code possibly live in window watcher? Or is the problem that this code needs to run before we create an inner window there? We should probably file a followup to fix for 1.9 to make this work without depending on our chrome code.

Oh, is it me or is the aCalleePrincipal argument something we could remove? Everyone seems to pass the same thing for it...