Comment 1 for bug 1052056

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

MIR review:
 * it builds with only main enably
 * it does not have a testsuite. It does have a document for testing instructions in doc/freeipmi-testing.txt
 * there is no Ubuntu delta
 * it was a watch file
 * upstream is active
 * Debian is several releases behind
 * So long as there is no Ubuntu delta, it should be easy to maintain
 * not lintian clean (manpage errors)
 * debian/rules is not simple, but is readable, using dh
 * there are some compiler warnings:
bmc-watchdog.c:1695:15: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
bmc-watchdog.c:1721:12: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
ipmidetectd.c:72:11: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
ipmidetectd.c:89:9: warning: ignoring return value of 'chdir', declared with attribute warn_unused_result [-Wunused-result]
ipmidetectd.c:92:8: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
 * there is one open Debian bug. There are 2 open Ubuntu bugs