Comment 10 for bug 1187742

Revision history for this message
Robie Basak (racb) wrote : Re: [Bug 1187742] Re: [patch] upstart job for freeradius

On Tue, Aug 26, 2014 at 01:56:53PM -0000, Eloy Paris wrote:
> The symlinks in the /etc/rc?.d directories are still in place after the
> upstart job for FreeRADIUS was added via this bug. Is this correct or
> there is nothing that prevents both the init.d script and the upstart
> job from attempting to start the job?

No, this is fine. I think. It allows a system to switch init systems,
since we're in a multiple init system world now. I believe the packaging
and/or dh_installinit makes sure to not stop duplicate jobs. However,
the user can still do it accidentally, which is bug 1273462. In general,
in this new world users should always use the "service" wrapper to make
sure that the right thing happens.

> Also, the upstart job seems to be tracking incorrectly the freeradius
> process as "reload freeradius" does not work. I notice that the upstart
> job does not run the FreeRADIUS executable as a daemon (-f specified) so
> a PID file is not written to /var/run/freeradius. The init.d script does
> run the server as a daemon, which is probably more correct.
>
> Should separate bugs be filed for these two issues?

I'm not sure this is a bug exactly, since upstart tracks processes so a
PID file shouldn't be needed for a reload, by upstart at least. Running
in the foreground isn't necessarily a problem here, either, depending on
how the process handles that flag.

But if you want to discuss this further, a separate bug would be
useful, since this one is "Fix Released" and so we can't track any
status for your concerns.