Comment 15 for bug 60448

Revision history for this message
Matt Zimmerman (mdz) wrote : Re: SRU Proposal: Limit .xsession-errors file size to prevent disk space DoS

On Thu, Oct 26, 2006 at 06:03:19PM +0200, Martin Pitt wrote:
> Hi Matt,
>
> I propose to fix https://launchpad.net/bugs/60448 for dapper.
>
> Impact: if an application goes wild and dumps large amounts of logging
> to ~/.xsession-errors, there is nothing to clean up this file
> and limit its size.
>
> Edgy fix: http://librarian.launchpad.net/4679751/xorg.60448.debdiff
> (xorg 1:7.1.1ubuntu2, Oct 5)
> Xsession checks if the file is > 0.5 MB and if so, only keeps
> the last 0.5 MB of data.
>
> Proposed dapper fix: http://librarian.launchpad.net/4937364/xinit.60448.diff
> Very same patch (just different package, the file has moved)
>
> This does not affect systems using gdm, since gdm uses its own
> Xsession script which completely removes the file. I tested the fix on
> a clean Dapper with using xdm, for both cases (small and large file).

Wouldn't it be simpler and cleaner to rotate the file to .old or such,
rather than attempting to rotate the data within the file?

--
 - mdz