Huh, you do realize this is written in C++ using Gtkmm, right? ;-)
I beg to differ on the proper fix:
diff --git a/src/finddialog.cpp b/src/finddialog.cpp index d322395..3433b86 100644 --- a/src/finddialog.cpp +++ b/src/finddialog.cpp @@ -49,8 +49,8 @@ Gobby::FindDialog::FindDialog(Gobby::Window& parent): m_radio_up(m_group_direction, _("_Up"), true), m_radio_down(m_group_direction, _("_Down"), true), m_btn_find(Gtk::Stock::FIND), - m_btn_replace(_("_Replace") ), - m_btn_replace_all(_("Replace _all") ), + m_btn_replace(_("_Replace"), true), + m_btn_replace_all(_("Replace _all"), true), m_btn_close(Gtk::Stock::CLOSE), m_regex("") {
Rationale: The button creation misses the mnemonic=true flag, which boils down to the same as your patch but is much cleaner. As you see for m_radio_{up,down}: it does the same. I'll commit this upstream shortly.
Huh, you do realize this is written in C++ using Gtkmm, right? ;-)
I beg to differ on the proper fix:
diff --git a/src/finddialo g.cpp b/src/finddialo g.cpp g.cpp g.cpp FindDialog: :FindDialog( Gobby:: Window& parent):
m_radio_ up(m_group_ direction, _("_Up"), true),
m_radio_ down(m_ group_direction , _("_Down"), true),
m_btn_ find(Gtk: :Stock: :FIND), _("_Replace" ) ), all(_(" Replace _all") ), _("_Replace" ), true), all(_(" Replace _all"), true),
m_btn_ close(Gtk: :Stock: :CLOSE) ,
index d322395..3433b86 100644
--- a/src/finddialo
+++ b/src/finddialo
@@ -49,8 +49,8 @@ Gobby::
- m_btn_replace(
- m_btn_replace_
+ m_btn_replace(
+ m_btn_replace_
m_regex("")
{
Rationale: The button creation misses the mnemonic=true flag, which boils down to the same as your patch but is much cleaner. As you see for m_radio_{up,down}: it does the same. I'll commit this upstream shortly.