Comment 1 for bug 519553

Revision history for this message
Dylan McCall (dylanmccall) wrote :

Linked in a branch with one possible fix, successfully built and tested on the latest Lucid.

As I suggested, it gets rid of the context menu when the user right clicks over an indicator icon, since users could falsely see the menu which appears as relative to the specific icon. As a result, for example, Remove from Panel may be interpreted as removing a specific indicator from the panel but in fact removes the entire applet.

It adds a handle to the panel applet using the necessary hint. Two reasons for this:
 * We need somewhere else to put a context menu for the entire applet, as mentioned.
 * Applet could exist on the panel with no other contents. The handle functionality is intended for this case, so we should use it. (See window list applet and notification area).

I changed menubar_press to suppress the context menu completely for anything but a left click. This could do with some debate. It is possible to have this behave exactly like a normal menu by removing the menubar_press function. However, no other applets behave like normal menus in GNOME 2.x. So, having this one work that way could give the user a false impression and lead to confusion when interacting with other applets.