Ubuntu
laptop-mode-tools package

  1. Bug #422620
  2. Comment #16

Comment 16 for bug 422620

Revision history for this message
Steve Langasek (vorlon) wrote :

Feedback on the proposed merge:

- the Debian package adds handling in the postinst for restarting the various power management daemons that it hooks into, but the merge drops these postinst changes. Why? Either the functionality of the two postinst scripts should be merged, or the reason for dropping the Debian changes should be documented in the changelog.
- the Debian package adds handling for /usr/lib/pm-utils/power.d in a slightly different place within debian/rules than the Ubuntu package had it; since the behavior is identical, we should use the Debian code to reduce our delta.
- the usr/lib/pm-utils/sleep.d/99laptop-mode in the package includes undocumented changes wrt the Debian version - we shouldn't diverge from Debian on such minor things as setting a LAPTOP_MODE variable vs. repeating the path. We do need to remain consistent in our handling of $ENABLE_LAPTOP_MODE, however; and this should be documented in the changelog.

I'm making the changes described above, and will commit them to bzr for inclusion in the upload.